From: Sean Christopherson <seanjc@google.com>
To: Alexander Graf <graf@amazon.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com,
x86@kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
nh-open-source@amazon.com, gurugubs@amazon.com,
jalliste@amazon.co.uk, Michael Kelley <mhklinux@outlook.com>,
John Starks <jostarks@microsoft.com>
Subject: Re: [PATCH] kvm: hyper-v: Delay firing of expired stimers
Date: Fri, 23 Jan 2026 10:21:23 -0800 [thread overview]
Message-ID: <aXO8I6xuZyZB7CxV@google.com> (raw)
In-Reply-To: <20260115141520.24176-1-graf@amazon.com>
On Thu, Jan 15, 2026, Alexander Graf wrote:
> During Windows Server 2025 hibernation, I have seen Windows' calculation
> of interrupt target time get skewed over the hypervisor view of the same.
> This can cause Windows to emit timer events in the past for events that
> do not fire yet according to the real time source. This then leads to
> interrupt storms in the guest which slow down execution to a point where
> watchdogs trigger. Those manifest as bugchecks 0x9f and 0xa0 during
> hibernation, typically in the resume path.
>
> To work around this problem, we can delay timers that get created with a
> target time in the past by a tiny bit (10µs) to give the guest CPU time
> to process real work and make forward progress, hopefully recovering its
> interrupt logic in the process. While this small delay can marginally
> reduce accuracy of guest timers, 10µs are within the noise of VM
> entry/exit overhead (~1-2 µs) so I do not expect to see real world impact.
There is a lot of hope piled into this. And *always* padding the count makes me
more than a bit uncomfortable. If the skew is really due to a guest bug and not
something on the host's side, i.e. if this isn't just a symptom of a real bug that
can be fixed and the _only_ option is to chuck in a workaround, then I would
strongly prefer to be as conservative as possible. E.g. is it possible to
precisely detect this scenario and only add the delay when the guest appears to
be stuck?
> To still provide some level of visibility when this happens, add a trace
> point that clearly shows the discrepancy between the target time and the
> current time.
This honestly doesn't seem all that useful. As a debug tool, sure, but once the
workaround is in place, it doesn't seem like it'll add a lot of value since it
would require the end user to be aware of the workaround in the first place.
If we really want something, a stat or a pr_xxx_once() (even though I generally
dislike those) seems like it'd be more helpful.
next prev parent reply other threads:[~2026-01-23 18:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-15 14:15 [PATCH] kvm: hyper-v: Delay firing of expired stimers Alexander Graf
2026-01-23 18:21 ` Sean Christopherson [this message]
2026-01-24 21:26 ` Alexander Graf
2026-01-26 9:41 ` Vitaly Kuznetsov
2026-01-24 0:37 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXO8I6xuZyZB7CxV@google.com \
--to=seanjc@google.com \
--cc=graf@amazon.com \
--cc=gurugubs@amazon.com \
--cc=hpa@zytor.com \
--cc=jalliste@amazon.co.uk \
--cc=jostarks@microsoft.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhklinux@outlook.com \
--cc=nh-open-source@amazon.com \
--cc=pbonzini@redhat.com \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.