All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ming Lei <ming.lei@redhat.com>
To: Alexander Atanasov <alex@zazolabs.com>
Cc: Shuah Khan <shuah@kernel.org>, Jens Axboe <axboe@kernel.dk>,
	Caleb Sander Mateos <csander@purestorage.com>,
	linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] selftests: ublk: add missing gitignore for metadata_size binary
Date: Sun, 25 Jan 2026 22:25:47 +0800	[thread overview]
Message-ID: <aXYn66eXcs-I1Bin@fedora> (raw)
In-Reply-To: <20260125085747.1631424-1-alex@zazolabs.com>

On Sun, Jan 25, 2026 at 08:57:46AM +0000, Alexander Atanasov wrote:
> A new utility metadata_size was added in
> commit 261b67f4e347 ("selftests: ublk: add utility to get block device metadata size")
> but it was not added to .gitignore. Fix that by adding it there.
> 
> While at it sort all entries alphabetically and add a SPDX license header.
> 
> Reviewed-by: Caleb Sander Mateos <csander@purestorage.com>
> Fixes: 261b67f4e347 ("selftests: ublk: add utility to get block device metadata size")
> Signed-off-by: Alexander Atanasov <alex@zazolabs.com>
> ---
>  tools/testing/selftests/ublk/.gitignore | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> v1->v2:
>  - add SPDX license header
>  - sort alphabetically as suggested by Caleb Sander Mateos
> 
> It is also Reviewed-by: Ming Lei <ming.lei@redhat.com> but it needs an Ack from him,
> as he is the original author of the file, for the license header.
> 
> 
> diff --git a/tools/testing/selftests/ublk/.gitignore b/tools/testing/selftests/ublk/.gitignore
> index 8b2871ea7751..e17bd28f27e0 100644
> --- a/tools/testing/selftests/ublk/.gitignore
> +++ b/tools/testing/selftests/ublk/.gitignore
> @@ -1,3 +1,5 @@
> -kublk
> -/tools
> +# SPDX-License-Identifier: GPL-2.0
>  *-verify.state
> +/tools
> +kublk
> +metadata_size

Reviewed-by: Ming Lei <ming.lei@redhat.com>


Thanks,
Ming


  reply	other threads:[~2026-01-25 14:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-25  8:57 [PATCH v2] selftests: ublk: add missing gitignore for metadata_size binary Alexander Atanasov
2026-01-25 14:25 ` Ming Lei [this message]
2026-01-25 17:12 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXYn66eXcs-I1Bin@fedora \
    --to=ming.lei@redhat.com \
    --cc=alex@zazolabs.com \
    --cc=axboe@kernel.dk \
    --cc=csander@purestorage.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.