From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [91.216.245.30]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABAEC331207 for ; Mon, 26 Jan 2026 12:08:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.216.245.30 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769429311; cv=none; b=IxCDYS3D834Yip1O+UJDIDgCQbPLz9QhKYspBkK2mzWEEwtFA5iUtvQ3zOdJCGOyV1IYSHIK9fSmFeRMSe03waCML4ERVaQdCdM28iOxZJ1Wn8KoyqVCP4M6R+tFZxj5RfKYgb3tB7F/g47SeRmkwpEJuFzEXlPyrKVw62nFsDE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769429311; c=relaxed/simple; bh=+opHtG6Eg7VYlzG5KZnzUI5x38ffcotbF1fKJ83Ocg8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=SA97RQg988+rnUfnVjCCpbG8ZvcICmi8OghAWOqofc+A29Wv7taQx9duNFLweuDFrLyBFDBWBkX89Eo0NNCPPT9NtVv2OGCvy0aAQCTVknVyg43gceCcLg8veuJ3N9DuAT2XjAsusDwX9aZbednnp6kD6z5PR2beKX9z097vis4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de; spf=pass smtp.mailfrom=strlen.de; arc=none smtp.client-ip=91.216.245.30 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=strlen.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=strlen.de Received: by Chamillionaire.breakpoint.cc (Postfix, from userid 1003) id ECDF26033F; Mon, 26 Jan 2026 13:08:21 +0100 (CET) Date: Mon, 26 Jan 2026 13:08:21 +0100 From: Florian Westphal To: Brian Witte Cc: netfilter-devel@vger.kernel.org Subject: Re: [nft PATCH] datatype: fix ether address parsing of integer values Message-ID: References: <20260126061746.368011-1-brianwitte@mailfence.com> Precedence: bulk X-Mailing-List: netfilter-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260126061746.368011-1-brianwitte@mailfence.com> Brian Witte wrote: > When parsing "ether daddr 0x64", integer_expr converts the hex value > to decimal string "100". lladdr_type_parse then interprets this as > hex, yielding 0x100 = 256 which exceeds the single-byte limit. Yes, but it looks like it breaks backwards compatibility. 'ether daddr 99' is parsed as 00:00:00:00:00:99. After your patch, its parsed as 00:00:00:00:00:63. So I'm not sure we can fix this.