From: Simon Horman <horms@kernel.org>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Peter Korsgaard <peter@korsgaard.com>
Subject: Re: [PATCH net-next] net: usb: sr9700: remove code to drive nonexistent multicast filter
Date: Mon, 26 Jan 2026 13:42:30 +0000 [thread overview]
Message-ID: <aXdvRs1hAC5E4Dex@horms.kernel.org> (raw)
In-Reply-To: <20260123065842.53669-1-enelsonmoore@gmail.com>
On Thu, Jan 22, 2026 at 10:58:32PM -0800, Ethan Nelson-Moore wrote:
> Several registers referenced in this driver's source code do not
> actually exist (they are not writable and read as zero in my testing).
> They exist in this driver because it originated as a copy of the dm9601
> driver. Notably, these include the multicast filter registers - this
> causes the driver to not support multicast packets correctly. Remove
> the multicast filter code and instead set the chip to receive all
> multicast filter packets when any multicast addresses are in the list.
> Also take the opportunity to remove definitions for a few other
> nonexistent registers, and a couple pointless comments.
>
> Signed-off-by: Ethan Nelson-Moore <enelsonmoore@gmail.com>
I would slightly lean towards splitting this patch up,
say one for the multicast changes and removal of related #defines,
and another for the remainder of the #define clean-up.
But that notwithstanding this looks good to me.
Reviewed-by: Simon Horman <horms@kernel.org>
next prev parent reply other threads:[~2026-01-26 13:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 6:58 [PATCH net-next] net: usb: sr9700: remove code to drive nonexistent multicast filter Ethan Nelson-Moore
2026-01-26 13:42 ` Simon Horman [this message]
2026-01-27 5:37 ` Ethan Nelson-Moore
2026-01-27 12:56 ` Simon Horman
2026-01-27 3:26 ` Jakub Kicinski
2026-01-27 4:17 ` Ethan Nelson-Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXdvRs1hAC5E4Dex@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=enelsonmoore@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peter@korsgaard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.