From: Ming Lei <ming.lei@redhat.com>
To: Alexander Atanasov <alex@zazolabs.com>
Cc: Shuah Khan <shuah@kernel.org>,
linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] selftests: ublk: mark each test start and end time in dmesg
Date: Mon, 26 Jan 2026 21:49:06 +0800 [thread overview]
Message-ID: <aXdw0hCiXhxSBPfE@fedora> (raw)
In-Reply-To: <20260126112544.1811817-2-alex@zazolabs.com>
On Mon, Jan 26, 2026 at 11:25:44AM +0000, Alexander Atanasov wrote:
> Log test start and end time in dmesg, so generated log messages
> during the test run can be linked to specific test from the test
> suite.
>
> Signed-off-by: Alexander Atanasov <alex@zazolabs.com>
> ---
> tools/testing/selftests/ublk/test_common.sh | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/testing/selftests/ublk/test_common.sh b/tools/testing/selftests/ublk/test_common.sh
> index ab1ea5cc904a..5865f1e640ce 100755
> --- a/tools/testing/selftests/ublk/test_common.sh
> +++ b/tools/testing/selftests/ublk/test_common.sh
> @@ -122,6 +122,7 @@ _prep_test() {
> modprobe ublk_drv > /dev/null 2>&1
> UBLK_TMP=$(mktemp $TMPDIR/ublk_test_XXXXX)
> [ "$UBLK_TEST_QUIET" -eq 0 ] && echo "ublk $type: $*"
> + echo "ublk selftest: $TID starting at $(date --iso-8601=sec)" | tee /dev/kmsg
> }
>
> _remove_test_files()
> @@ -166,6 +167,7 @@ _cleanup_test() {
> "${UBLK_PROG}" del -a
>
> _remove_files
> + echo "ublk selftest: $TID done at $(date --iso-8601=sec)" | tee /dev/kmsg
This patch is one nice improvement!
But it can't be applied cleanly on block/for-7.0/block, can you base it
against for-7.0/block branch of block tree?
https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux.git/log/?h=for-7.0/block
```
[root@ktest-40 linux]# git am raw.16
Applying: selftests: ublk: mark each test start and end time in dmesg
error: patch failed: tools/testing/selftests/ublk/test_common.sh:122
error: tools/testing/selftests/ublk/test_common.sh: patch does not apply
Patch failed at 0001 selftests: ublk: mark each test start and end time in dmesg
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
```
Thanks,
Ming
next prev parent reply other threads:[~2026-01-26 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 11:25 [PATCH] selftests: ublk: mark each test start and end time in dmesg Alexander Atanasov
2026-01-26 13:49 ` Ming Lei [this message]
2026-01-26 14:03 ` Ming Lei
2026-01-26 15:56 ` Alexander Atanasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXdw0hCiXhxSBPfE@fedora \
--to=ming.lei@redhat.com \
--cc=alex@zazolabs.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.