From: Christoph Hellwig <hch@infradead.org>
To: Coly Li <colyli@fnnas.com>
Cc: Christoph Hellwig <hch@infradead.org>,
zhangshida2026@163.com, kent.overstreet@linux.dev,
axboe@kernel.dk, osandov@fb.com, bvanassche@acm.org,
linux-bcache@vger.kernel.org, linux-kernel@vger.kernel.org,
zhangshida@kylinos.cn, starzhangzsd@gmail.com
Subject: Re: [PATCH v2] bcache: fix I/O accounting leak in detached_dev_do_request
Date: Mon, 26 Jan 2026 07:02:49 -0800 [thread overview]
Message-ID: <aXeCGcsQ3XnwWaOK@infradead.org> (raw)
In-Reply-To: <aXd_QlcF1h9qeULs@studio.local>
On Mon, Jan 26, 2026 at 11:00:56PM +0800, Coly Li wrote:
> > I don't think that is correct. This was just a trivial calling
> > convention change.
> >
>
> Hi Shida,
>
> This Fixes tag is misleading. The correct to-be-fixed patch is commit
> 3ef825dfd4e4 ("bcache: use bio cloning for detached device requests")
> in linux-block/block-6.19 branch.
Not really. The missing accounting was present before for the no-op
discard case. See my reply for what I think is the culprit.
next prev parent reply other threads:[~2026-01-26 15:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 9:28 [PATCH v2] bcache: fix I/O accounting leak in detached_dev_do_request zhangshida2026
2026-01-26 12:52 ` Christoph Hellwig
2026-01-26 15:00 ` Coly Li
2026-01-26 15:02 ` Christoph Hellwig [this message]
2026-01-27 2:11 ` zhangshida2026
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXeCGcsQ3XnwWaOK@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=colyli@fnnas.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=osandov@fb.com \
--cc=starzhangzsd@gmail.com \
--cc=zhangshida2026@163.com \
--cc=zhangshida@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.