Re: [REPORT] Double deletion of output directory in functional test

["Daniel P. Berrangé" <berrange@redhat.com>]

On Mon, Jan 26, 2026 at 12:48:00PM -0300, Fabiano Rosas wrote:
> Aditya Gupta <adityag@linux.ibm.com> writes:
> 
> > +harsh
> >
> > On 23/01/26 20:07, Aditya Gupta wrote:
> >
> >> Hello,
> >>
> >> I notice a test failure with ppc64 functional tests, which only occurs when
> >> tests are run in parallel ('make check-functional-ppc64 -j8').
> >>
> >> I believe the issue might be with the generic migration testcase. The following
> >> backtrace happens on error:
> >>
> >> 	Traceback (most recent call last):
> >> 	  File "<SRC_DIR>/tests/functional/qemu_test/testcase.py", line 421, in tearDown
> >> 	    super().tearDown()
> >> 	  File "<SRC_DIR>/tests/functional/qemu_test/testcase.py", line 238, in tearDown
> >> 	    shutil.rmtree(self.workdir)
> >> 	  File "/usr/lib64/python3.11/shutil.py", line 742, in rmtree
> >> 	    onerror(os.lstat, path, sys.exc_info())
> >> 	  File "/usr/lib64/python3.11/shutil.py", line 740, in rmtree
> >> 	    orig_st = os.lstat(path, dir_fd=dir_fd)
> >> 	              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> >> 	FileNotFoundError: [Errno 2] No such file or directory: '<SRC_DIR>/build/tests/functional/ppc64/test_migration.PpcMigrationTest.test_migration_with_exec/scratch'
> >
> > Git bisect points to this:
> >
> >
> >      f4e34d0fd56c25dd0c90722ed80a83a175160a6c is the first bad commit
> >      commit f4e34d0fd56c25dd0c90722ed80a83a175160a6c
> >      Date:   Fri Jan 9 09:35:19 2026 -0300
> >
> >          tests/functional: Add a OS level migration test for pseries
> >
> 
> I see, the test I added imports PpcMigrationTest which causes it to be
> instantiated by unittest and the setup method races with another test
> that uses the same class. I'll send a patch.

While looking at the issues in mail, I noticed another minor bug in
tests/functional/migration.py.  It is directly using the TemporaryDirectory
class to create a dir for UNIX sockets, when it should use  self.socket_dir()
so we get consistent dir prefixes.

With regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|