From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Kees Cook <kees@kernel.org>,
"Darrick J . Wong" <djwong@kernel.org>,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH v3 0/3] lib and lib/cmdline enhancements
Date: Mon, 26 Jan 2026 18:44:33 +0200 [thread overview]
Message-ID: <aXeZ8Wx3YGBe666p@smile.fi.intel.com> (raw)
In-Reply-To: <aXeZo2PJlXEuPjIZ@smile.fi.intel.com>
On Mon, Jan 26, 2026 at 06:43:19PM +0200, Andy Shevchenko wrote:
> On Mon, Jan 26, 2026 at 07:20:56PM +0300, Dmitry Antipov wrote:
> > Adjust '_parse_integer_limit()' to not ignore overflows, add KUnit-based
> > test for 'memparse()' and fix kernel-doc glitches found in lib/cmdline.c.
>
> Shouldn't we also add test cases to lib/test-kstrtox.c?
Actually I think some of what you added for memparse(), should be moved to
test-kstrtox.c as they test the beneath implementation rather than memparse()
added code.
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2026-01-26 16:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 16:20 [PATCH v3 0/3] lib and lib/cmdline enhancements Dmitry Antipov
2026-01-26 16:20 ` [PATCH v3 1/3] lib: fix _parse_integer_limit() to handle overflow Dmitry Antipov
2026-01-26 16:39 ` Andy Shevchenko
2026-01-26 16:20 ` [PATCH v3 2/3] lib/cmdline_kunit: add test case for memparse() Dmitry Antipov
2026-01-26 16:41 ` Andy Shevchenko
2026-01-26 16:20 ` [PATCH v3 3/3] lib/cmdline: adjust a few comments to fix kernel-doc -Wreturn warnings Dmitry Antipov
2026-01-26 16:43 ` [PATCH v3 0/3] lib and lib/cmdline enhancements Andy Shevchenko
2026-01-26 16:44 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXeZ8Wx3YGBe666p@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=akpm@linux-foundation.org \
--cc=djwong@kernel.org \
--cc=dmantipov@yandex.ru \
--cc=kees@kernel.org \
--cc=linux-hardening@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.