All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: Fabiano Rosas <farosas@suse.de>
Cc: qemu-devel@nongnu.org, Prasad Pandit <ppandit@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Juraj Marcin <jmarcin@redhat.com>
Subject: Re: [PATCH v2 0/5] migration: Notifier fixes for 11.0
Date: Mon, 26 Jan 2026 17:36:59 -0500	[thread overview]
Message-ID: <aXfsi29uRfzPJUlp@x1.local> (raw)
In-Reply-To: <87y0lkf2tl.fsf@suse.de>

On Mon, Jan 26, 2026 at 07:04:38PM -0300, Fabiano Rosas wrote:
> Queued, let me know if you want to change patch 2.

Thanks. I have no strong preference.

Considering that cpr-exec's execve() is not designed to fail at all at
least in production, and FAILED after DONE is utterly confusing.. maybe we
don't need to mention it in a doc everyone would read?  I actually instead
hope nobody noticed it's even possible..

I believe that code was there only because when Steve worked on it he
wanted to trap when he typed something wrong by accident when testing
cpr-exec.  It's a feature too special and mustn't used wrong or VM data can
definitely get lost.  From that POV, maybe some day later we can use an
g_assert_not_reached() to replace that whole blob, including the notify.

-- 
Peter Xu



      reply	other threads:[~2026-01-26 22:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 21:36 [PATCH v2 0/5] migration: Notifier fixes for 11.0 Peter Xu
2026-01-26 21:36 ` [PATCH v2 1/5] migration: Add a tracepoint for invoking migration notifiers Peter Xu
2026-01-26 21:36 ` [PATCH v2 2/5] migration: Fix double notification of DONE/FAIL for postcopy Peter Xu
2026-01-26 22:03   ` Fabiano Rosas
2026-01-26 21:36 ` [PATCH v2 3/5] migration: Notify migration FAILED before starting VM Peter Xu
2026-01-26 21:36 ` [PATCH v2 4/5] migration: Drop explicit block activation in postcopy fail path Peter Xu
2026-01-26 21:36 ` [PATCH v2 5/5] migration: Rename MIG_EVENT_PRECOPY_* to MIG_EVENT_* Peter Xu
2026-01-26 22:04 ` [PATCH v2 0/5] migration: Notifier fixes for 11.0 Fabiano Rosas
2026-01-26 22:36   ` Peter Xu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXfsi29uRfzPJUlp@x1.local \
    --to=peterx@redhat.com \
    --cc=farosas@suse.de \
    --cc=jmarcin@redhat.com \
    --cc=ppandit@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.