Re: [PATCH 18/27] hw/core/machine: add '-hw-dtb' option for machine

[Zhao Liu <zhao1.liu@intel.com>]

>  static char *machine_get_dumpdtb(Object *obj, Error **errp)
>  {
>      MachineState *ms = MACHINE(obj);
> @@ -1287,6 +1301,11 @@ static void machine_initfn(Object *obj)
>      ms->ram_size = mc->default_ram_size;
>      ms->maxram_size = mc->default_ram_size;
>  
> +    object_property_add_str(obj, "hw-dtb",
> +                            machine_get_hw_dtb, machine_set_hw_dtb);

What about object_class_property_add_str()? It seems this property
doesn't depend on any other state, so I think it could be at class
level, just like "dtb" did.

> +    object_property_set_description(obj, "hw-dtb",
> +                    "A device tree used to describe the hardware to QEMU.");

maybe "A device tree binary used to describe the hardware to QEMU"?

and none of the other machine property descriptions have 'periods'.

> +
>      if (mc->nvdimm_supported) {
>          ms->nvdimms_state = g_new0(NVDIMMState, 1);
>          object_property_add_bool(obj, "nvdimm",