From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Ethan Nelson-Moore <enelsonmoore@gmail.com>
Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org,
"Andrew Lunn" <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Paolo Abeni" <pabeni@redhat.com>,
"Thangaraj Samynathan" <Thangaraj.S@microchip.com>,
"Rengarajan Sundararajan" <Rengarajan.S@microchip.com>,
UNGLinuxDriver@microchip.com,
"Petko Manolov" <petkan@nucleusys.com>,
"Oliver Neukum" <oneukum@suse.com>,
"Nikita Zhandarovich" <n.zhandarovich@fintech.ru>,
"Krzysztof Hałasa" <khalasa@piap.pl>,
"Deepanshu Kartikey" <kartikey406@gmail.com>,
"Thomas Gleixner" <tglx@kernel.org>,
"Ingo Molnar" <mingo@kernel.org>,
"Foster Snowhill" <forst@pen.gy>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
"Kees Cook" <kees@kernel.org>,
"Eric Biggers" <ebiggers@google.com>
Subject: Re: [PATCH net-next] net: usb: switch to two-argument strscpy
Date: Tue, 27 Jan 2026 09:27:29 +0200 [thread overview]
Message-ID: <aXho4UtIhBn4Rb9c@smile.fi.intel.com> (raw)
In-Reply-To: <aXc89lDpfHQFVX-7@smile.fi.intel.com>
On Mon, Jan 26, 2026 at 12:07:57PM +0200, Andy Shevchenko wrote:
> On Sun, Jan 25, 2026 at 07:50:15PM -0800, Ethan Nelson-Moore wrote:
> > All instances of strscpy in the USB network drivers use the size of the
> > destination. If given only two arguments, strscpy will automatically
> > use the size of the destination. Make the code more concise by
> > switching to the two-argument form of strscpy.
> >
> > Also add a blank line after a variable declaration in catc.c to adhere
> > to kernel code style, since the surrounding code is being touched.
>
> It should go after your patch that drops some of the strscpy():s.
> Hence make a v3 as a series of two patches.
FWIW, your v3 missed this patch... What's your plan with it?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-27 7:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 3:50 [PATCH net-next] net: usb: switch to two-argument strscpy Ethan Nelson-Moore
2026-01-26 10:07 ` Andy Shevchenko
2026-01-27 7:27 ` Andy Shevchenko [this message]
2026-01-28 1:52 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXho4UtIhBn4Rb9c@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Rengarajan.S@microchip.com \
--cc=Thangaraj.S@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=ebiggers@google.com \
--cc=edumazet@google.com \
--cc=enelsonmoore@gmail.com \
--cc=forst@pen.gy \
--cc=gustavoars@kernel.org \
--cc=kartikey406@gmail.com \
--cc=kees@kernel.org \
--cc=khalasa@piap.pl \
--cc=kuba@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=n.zhandarovich@fintech.ru \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=pabeni@redhat.com \
--cc=petkan@nucleusys.com \
--cc=tglx@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.