From: Simon Horman <horms@kernel.org>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: "Russell King (Oracle)" <linux@armlinux.org.uk>,
robh@kernel.org, kuba@kernel.org, festevam@gmail.com,
ghennadi.procopciuc@oss.nxp.com, alexandre.torgue@foss.st.com,
linux-kernel@vger.kernel.org, andrew+netdev@lunn.ch,
shawnguo@kernel.org, mbrugger@suse.com,
mcoquelin.stm32@gmail.com, linaro-s32@linaro.org,
davem@davemloft.net, s.hauer@pengutronix.de, edumazet@google.com,
linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev,
conor+dt@kernel.org, krzk+dt@kernel.org,
devicetree@vger.kernel.org, Frank.li@nxp.com,
chester62515@gmail.com, netdev@vger.kernel.org,
kernel@pengutronix.de, pabeni@redhat.com,
jan.petrous@oss.nxp.com,
linux-stm32@st-md-mailman.stormreply.com, s32@nxp.com
Subject: Re: [v4,1/3] net: stmmac: s32: use a syscon for S32_PHY_INTF_SEL_RGMII
Date: Tue, 27 Jan 2026 12:57:24 +0000 [thread overview]
Message-ID: <aXi2NJcwM4-mrgrj@horms.kernel.org> (raw)
In-Reply-To: <aXh9lcfw6D6KouI_@stanley.mountain>
On Tue, Jan 27, 2026 at 11:55:49AM +0300, Dan Carpenter wrote:
> On Mon, Jan 26, 2026 at 04:01:27PM +0000, Simon Horman wrote:
> > But at any rate, I think the key question is should the case
> > where regmap_write() returns an error be handled in
> > s32_gmac_write_phy_intf_select() (by some means)?
>
> Generally if register read/writes fail then there is nothing you
> can do a the software level, you need to buy a new computer. However,
> in this case we may eventually put the registers behind an SCMI
> interface so probably checking is a good idea.
>
> Could I leave the error message out? The callers has an error
> message and if you ever see the error message, and even with SCMI,
> the fix is probably still to buy a new computer.
FWIIW, that seems reasonable to me.
next prev parent reply other threads:[~2026-01-27 12:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 19:51 [PATCH v4 0/3] s32g: Use a syscon for GPR Dan Carpenter
2026-01-23 19:51 ` [PATCH v4 1/3] net: stmmac: s32: use a syscon for S32_PHY_INTF_SEL_RGMII Dan Carpenter
2026-01-26 15:24 ` [v4,1/3] " Simon Horman
2026-01-26 15:33 ` Russell King (Oracle)
2026-01-26 16:01 ` Simon Horman
2026-01-27 8:55 ` Dan Carpenter
2026-01-27 12:57 ` Simon Horman [this message]
2026-01-23 19:51 ` [PATCH v4 2/3] dt-bindings: net: nxp,s32-dwmac: Use the GPR syscon Dan Carpenter
2026-01-26 15:45 ` Rob Herring (Arm)
2026-01-23 19:51 ` [PATCH v4 3/3] dts: s32g: Add GPR syscon region Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXi2NJcwM4-mrgrj@horms.kernel.org \
--to=horms@kernel.org \
--cc=Frank.li@nxp.com \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew+netdev@lunn.ch \
--cc=chester62515@gmail.com \
--cc=conor+dt@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=festevam@gmail.com \
--cc=ghennadi.procopciuc@oss.nxp.com \
--cc=imx@lists.linux.dev \
--cc=jan.petrous@oss.nxp.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linaro-s32@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=linux@armlinux.org.uk \
--cc=mbrugger@suse.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=s32@nxp.com \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.