All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kris Van Hees <kris.van.hees@oracle.com>
To: Nick Alcock <nick.alcock@oracle.com>
Cc: "eugene.loh--- via DTrace-devel" <dtrace-devel@oss.oracle.com>,
	dtrace@lists.linux.dev, eugene.loh@oracle.com
Subject: Re: [DTrace-devel] [PATCH] test: Account for readahead tracepoints
Date: Tue, 27 Jan 2026 10:11:00 -0500	[thread overview]
Message-ID: <aXjVhMpPmlQivQZp@oracle.com> (raw)
In-Reply-To: <87h5s72p17.fsf@esperi.org.uk>

On Tue, Jan 27, 2026 at 12:55:32PM +0000, Nick Alcock wrote:
> On 22 Jan 2026, eugene loh uttered the following:
> 
> > From: Eugene Loh <eugene.loh@oracle.com>
> >
> > Some tests check for empty probe descriptions.  In some cases, the tests
> > relied on the absence of any read* modules.
> 
> Argh! Sorry, this was my bug way back when. I don't know why I thought
> this would work in the long term...
> 
> > However, some kernels can have "readahead" tracepoints.  Tests expecting
> > no read* modules will therefore fail.
> >
> > Change these tests to ask for readfoo* modules to ensure that the probe
> > descriptions will indeed find no probes.

But this commit message surely needs fixing because "read*" surely refers to
the tracepoint names and not to the module names.

> >
> > Signed-off-by: Eugene Loh <eugene.loh@oracle.com>
> 
> Reviewed-by: Nick Alcock <nick.alcock@oracle.com>
> 
> -- 
> NULL && (void)

      reply	other threads:[~2026-01-27 15:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-22  7:23 [PATCH] test: Account for readahead tracepoints eugene.loh
2026-01-27 12:55 ` [DTrace-devel] " Nick Alcock
2026-01-27 15:11   ` Kris Van Hees [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXjVhMpPmlQivQZp@oracle.com \
    --to=kris.van.hees@oracle.com \
    --cc=dtrace-devel@oss.oracle.com \
    --cc=dtrace@lists.linux.dev \
    --cc=eugene.loh@oracle.com \
    --cc=nick.alcock@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.