From: Phil Sutter <phil@nwl.cc>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: netfilter-devel@vger.kernel.org
Subject: Re: [nft PATCH v2 00/11] Fix netlink debug output on Big Endian
Date: Tue, 27 Jan 2026 23:04:43 +0100 [thread overview]
Message-ID: <aXk2e-JLML27vR-b@orbyte.nwl.cc> (raw)
In-Reply-To: <20251114002542.22667-1-phil@nwl.cc>
On Fri, Nov 14, 2025 at 01:25:31AM +0100, Phil Sutter wrote:
> Make use of recent changes to libnftnl to make test suites pass on both
> Little and Big Endian systems.
>
> Changes since v1:
> - First 12 patches accepted and pushed already, patches 27 and 28 as
> well
> - Minimize changes to existing code: Drop patch 13 changing string-based
> expressions to be defined as Big Endian as well as related patches 14,
> 17 and 18
> - Pull a fix for concatenated wildcard interface names upfront
> - Follow with set element sorting changes, with improved patch
> descriptions and related test suite record changes folded into them
> for clarification of practical effect
> - Review patch descriptions in general
> - Add special casing to patch 5 to avoid string-based values being
> printed in reverse by libnftnl, also communicate any byteorder
> conversions from __netlink_gen_concat_key() back to caller for the
> same purpose
>
> Patch 1 works around "funny" behaviour of GMP when partially exporting
> data and unwanted prefix-padding when exporting into an oversized
> buffer, all happening on Big Endian only.
>
> Patches 2 and 3 deal with sorting of set elements. They are effective on
> Little Endian only, changing sort ordering to match that of Big Endian.
>
> Patches 4 and 5 are preparation for the next two patches.
>
> Patches 6 and 7 collect data for calls to newly introduced libnftnl API
> functions (in patch 8) to communicate byte order and component sizes in
> data regs to libnftnl.
>
> Patch 10 contains the big payload records update, created with help from
> the script introduced in patch 9.
>
> Patch 11 still contains the expr_print_debug() macro definition for use
> with printf-debugging.
>
> Phil Sutter (11):
> segtree: Fix range aggregation on Big Endian
> mergesort: Fix sorting of string values
> mergesort: Align concatenation sort order with Big Endian
> intervals: Convert byte order implicitly
> expression: Set range expression 'len' field
> netlink: Introduce struct nft_data_linearize::byteorder
> netlink: Introduce struct nft_data_linearize::sizes
> netlink: Make use of nftnl_{expr,set_elem}_set_imm()
> tests: py: tools: Add regen_payloads.sh
> tests: py: Update payload records
> utils: Introduce expr_print_debug()
Series applied.
prev parent reply other threads:[~2026-01-27 22:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-14 0:25 [nft PATCH v2 00/11] Fix netlink debug output on Big Endian Phil Sutter
2025-11-14 0:25 ` [nft PATCH v2 01/11] segtree: Fix range aggregation " Phil Sutter
2025-11-14 0:25 ` [nft PATCH v2 02/11] mergesort: Fix sorting of string values Phil Sutter
2026-01-27 23:28 ` Pablo Neira Ayuso
2026-01-28 12:11 ` Phil Sutter
2025-11-14 0:25 ` [nft PATCH v2 03/11] mergesort: Align concatenation sort order with Big Endian Phil Sutter
2025-11-14 0:25 ` [nft PATCH v2 04/11] intervals: Convert byte order implicitly Phil Sutter
2025-11-14 0:25 ` [nft PATCH v2 05/11] expression: Set range expression 'len' field Phil Sutter
2025-11-14 0:25 ` [nft PATCH v2 06/11] netlink: Introduce struct nft_data_linearize::byteorder Phil Sutter
2025-11-14 0:25 ` [nft PATCH v2 07/11] netlink: Introduce struct nft_data_linearize::sizes Phil Sutter
2025-11-14 0:25 ` [nft PATCH v2 08/11] netlink: Make use of nftnl_{expr,set_elem}_set_imm() Phil Sutter
2025-11-14 0:25 ` [nft PATCH v2 09/11] tests: py: tools: Add regen_payloads.sh Phil Sutter
2025-11-14 0:25 ` [nft PATCH v2 10/11] tests: py: Update payload records Phil Sutter
2025-11-14 0:25 ` [nft PATCH v2 11/11] utils: Introduce expr_print_debug() Phil Sutter
2026-01-27 22:04 ` Phil Sutter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXk2e-JLML27vR-b@orbyte.nwl.cc \
--to=phil@nwl.cc \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.