From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0F24D2FEF5 for ; Tue, 27 Jan 2026 22:10:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=IRZWz65BVUY6i5SAhQ18tG5iXmFBKGXuMa2xvxzRLv0=; b=Q81yiTE1r17PTO Ct1kviwj6SYCPQ5m1sfDXP1vLNbdM9FJz6FL3BGZbrFvCdf5QokwcmDAfQlWdcGkBrgy2np3w8jOc xPTdeRLEFwMAKDsVu+Y2E+fTJ4xaG1qOl68m1EHeueRcwFSPkg0wCxv3lsi4VP265ldltaGZE4Wae KlDftLwDYnVmxa1woKL+iAfXxN1rGfqFIRWMTEjSzhHF15IqKto5TYWnjJ/h0kfOIPAm4K45jjFMp Gw75FcJfb6KXUroVMahnGWsxDm779XcCz+mHY0M9vf6ykWyyiD85MfOZcWsxE1OfQK9nr988UbRo4 zSMo38p3lXgzDTEmXHOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vkrGV-0000000F5en-3hMA; Tue, 27 Jan 2026 22:10:27 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vkrGT-0000000F5e0-2bRy for linux-riscv@lists.infradead.org; Tue, 27 Jan 2026 22:10:26 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sea.source.kernel.org (Postfix) with ESMTP id 243BA408DE; Tue, 27 Jan 2026 22:10:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D7BBC116C6; Tue, 27 Jan 2026 22:10:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769551824; bh=T1bfZ5aiqTQ/sFSevXZf16ujCOKTGhTUPz9xxVI+OQU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=asPY2b0P6PTxKcgn4M/EQv/eeC1mZP3TX0FYuO7SbRXPsYEaEM/LfHs4TtxZSRKZe xDQLyWtCJUluiWJd+ja/iK5bZTl2zLJCDWSLht/9SVQakZyMl1mzjL55OCIyvlMssf G9aHp9VaACCCCysb3hCy/ctc9+ej1Hby4dxXZwxjJC7leJlxqKdyUfzbfEysYyaZVc Y7UlCk3OUwxepQx1YU1F5cD0nUbQT7TeDR8+0psU/AuSN3tsl4Mf5uyxl/ipycliU+ awcN419Rv3urC4pBbrj11ub5xYPS3Zogq9x9jDFIbu8neFnBRsZnPCO4zVuRpF4stI CepEPah88+eXg== Date: Tue, 27 Jan 2026 14:10:22 -0800 From: Drew Fustini To: yunhui cui Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Radim =?utf-8?B?S3LEjW3DocWZ?= , Samuel Holland , Adrien Ricciardi , Nicolas Pitre , Kornel =?utf-8?Q?Dul=C4=99ba?= , Atish Patra , Atish Kumar Patra , Vasudevan Srinivasan , Ved Shanbhogue , Chen Pei , Liu Zhiwei , Weiwei Li , guo.wenjia23@zte.com.cn, liu.qingtao2@zte.com.cn, Conor Dooley , Krzysztof Kozlowski , Rob Herring , Reinette Chatre , Tony Luck , Babu Moger , Peter Newman , Fenghua Yu , James Morse , Ben Horgan , Dave Martin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org Subject: Re: [External] [PATCH RFC 08/19] RISC-V: QoS: add resctrl interface for CBQRI controllers Message-ID: References: <20260119-ssqosid-cbqri-v1-0-aa2a75153832@kernel.org> <20260119-ssqosid-cbqri-v1-8-aa2a75153832@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260127_141025_701886_85820FDB X-CRM114-Status: GOOD ( 18.81 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKYW4gMjYsIDIwMjYgYXQgMDE6MDI6MTJQTSAtMDgwMCwgRHJldyBGdXN0aW5pIHdy b3RlOgo+IE9uIE1vbiwgSmFuIDI2LCAyMDI2IGF0IDA5OjAxOjMwUE0gKzA4MDAsIHl1bmh1aSBj dWkgd3JvdGU6Cj4gPiBIaSBEcmV3LAo+ID4gCj4gPiBPbiBUdWUsIEphbiAyMCwgMjAyNiBhdCAx MjoxNeKAr1BNIERyZXcgRnVzdGluaSA8ZnVzdGluaUBrZXJuZWwub3JnPiB3cm90ZToKPiA+ID4K PiA+ID4gQWRkIGludGVyZmFjZSBmb3IgQ0JRUkkgY29udHJvbGxlciBkcml2ZXJzIHRvIG1ha2Ug dXNlIG9mIHRoZSByZXNjdHJsCj4gPiA+IGZpbGVzeXN0ZW0uCj4gPiA+Cj4gPiA+IENvLWRldmVs b3BlZC1ieTogQWRyaWVuIFJpY2NpYXJkaSA8YXJpY2NpYXJkaUBiYXlsaWJyZS5jb20+Cj4gPiA+ IFNpZ25lZC1vZmYtYnk6IEFkcmllbiBSaWNjaWFyZGkgPGFyaWNjaWFyZGlAYmF5bGlicmUuY29t Pgo+ID4gPiBTaWduZWQtb2ZmLWJ5OiBEcmV3IEZ1c3RpbmkgPGZ1c3RpbmlAa2VybmVsLm9yZz4K PiA+ID4gLS0tCj4gPiA+ICBhcmNoL3Jpc2N2L2tlcm5lbC9xb3MvcW9zX3Jlc2N0cmwuYyB8IDEx OTEgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiA+ID4gIDEgZmlsZSBjaGFu Z2VkLCAxMTkxIGluc2VydGlvbnMoKykKPiA+ID4KPiA+ID4gZGlmZiAtLWdpdCBhL2FyY2gvcmlz Y3Yva2VybmVsL3Fvcy9xb3NfcmVzY3RybC5jIGIvYXJjaC9yaXNjdi9rZXJuZWwvcW9zL3Fvc19y ZXNjdHJsLmMKPiA+ID4gbmV3IGZpbGUgbW9kZSAxMDA2NDQKPiA+ID4gaW5kZXggMDAwMDAwMDAw MDAwLi41ZTNhNjUzNDJlOWIKPiA+ID4gLS0tIC9kZXYvbnVsbAo+ID4gPiArKysgYi9hcmNoL3Jp c2N2L2tlcm5lbC9xb3MvcW9zX3Jlc2N0cmwuYwpbLi5dCj4gPiA+ICsgICAgICAgY2FzZSBSRFRf UkVTT1VSQ0VfTUJBOgo+ID4gPiArICAgICAgICAgICAgICAgLyogQ2FwYWNpdHkgcmVhZCBsaW1p dCBvcGVyYXRpb24gZm9yIFJDSUQgKGNsb3NpZCkgKi8KPiA+ID4gKyAgICAgICAgICAgICAgIGVy ciA9IGNicXJpX2JjX2FsbG9jX29wKGN0cmwsIENCUVJJX0NDX0FMTE9DX0NUTF9PUF9SRUFEX0xJ TUlULCBjbG9zaWQpOwo+ID4gPiArICAgICAgICAgICAgICAgaWYgKGVyciA8IDApIHsKPiA+ID4g KyAgICAgICAgICAgICAgICAgICAgICAgcHJfZXJyKCIlcygpOiBvcGVyYXRpb24gZmFpbGVkOiBl cnIgPSAlZCIsIF9fZnVuY19fLCBlcnIpOwo+ID4gPiArICAgICAgICAgICAgICAgICAgICAgICBy ZXR1cm4gLUVJTzsKPiA+ID4gKyAgICAgICAgICAgICAgIH0KPiA+ID4gKwo+ID4gPiArICAgICAg ICAgICAgICAgaHdfZG9tLT5jdHJsX3ZhbFtjbG9zaWRdID0gY2JxcmlfZ2V0X3Jid2IoY3RybCk7 Cj4gPiA+ICsKPiA+ID4gKyAgICAgICAgICAgICAgIC8qIENvbnZlcnQgZnJvbSBiYW5kd2lkdGgg YmxvY2tzIHRvIHBlcmNlbnQgKi8KPiA+ID4gKyAgICAgICAgICAgICAgIHJid2IgPSBod19kb20t PmN0cmxfdmFsW2Nsb3NpZF07Cj4gPiA+ICsgICAgICAgICAgICAgICByYndiICo9IDEwMDsKPiA+ ID4gKyAgICAgICAgICAgICAgIHBlcmNlbnQgPSByYndiIC8gY3RybC0+YmMubmJ3YmxrczsKPiA+ ID4gKyAgICAgICAgICAgICAgIGlmIChyYndiICUgY3RybC0+YmMubmJ3YmxrcykKPiA+ID4gKyAg ICAgICAgICAgICAgICAgICAgICAgcGVyY2VudCsrOwo+ID4gCj4gPiBzZXQ6IDEwLCBnZXQgMTEg Pwo+IAo+IFRoZSBpbnRlbnRpb24gd2FzIHRvIGhhbmRsZSByb3VuZGluZyB1cCBidXQgSSBjYW4g ZHJvcCB0aGlzIGluY3JlbWVudC4KCkFjdHVhbGx5LCB0aGlzIGluY3JlbWVudCBvZiBvbmUgaXMg bmVjZXNzYXJ5LiBXaXRob3V0IGl0LCB0aGUgZGVmYXVsdAp2YWx1ZSBvZiA4MCUgd2lsbCBiZSBk aXNwbGF5ZWQgYXMgNzklLiBBbmQgd3JpdGluZyBhIHZhbHVlIGxpa2UgNTUlIHdpbGwKcmVzdWx0 IGluIDU0JS4KCiMgbW91bnQgLXQgcmVzY3RybCByZXNjdHJsIC9zeXMvZnMvcmVzY3RybAojIGNk IC9zeXMvZnMvcmVzY3RybAojIGNhdCBzY2hlbWF0YQpNQjowPTc5OzE9Nzk7Mj03OQpMMjo0PWZm Zjs1PWZmZgpMMzozPWZmZmYKCiMgZWNobyAnTUI6Mj01NScgPiBzY2hlbWF0YQojIGNhdCBzY2hl bWF0YQpNQjowPTc5OzE9Nzk7Mj01NApMMjo0PWZmZjs1PWZmZgpMMzozPWZmZmYKCiMgZWNobyAn TUI6Mj04MCcgPiBzY2hlbWF0YQojIGNhdCBzY2hlbWF0YQpNQjowPTc5OzE9Nzk7Mj03OQpMMjo0 PWZmZjs1PWZmZgpMMzozPWZmZmYKClRoYW5rcywKRHJldwoKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4 LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFp bG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 686662FD1DC; Tue, 27 Jan 2026 22:10:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769551824; cv=none; b=OPbfZroYkGaL7U+PCUa0hq3qcBQcNF0jG4TtxO4bh3RRYK9Yudw9+/lLccvmeeHFS+Fhv6DyYiMbjjYnjCVlQcPJpZkfV5lu8pp2Rm2jd/NiflJVLXksMgkleqlUuHMPfxwtgHl/lAQ/+tbnk/85nhf/zfRlswFA5LSEyke0IE8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769551824; c=relaxed/simple; bh=T1bfZ5aiqTQ/sFSevXZf16ujCOKTGhTUPz9xxVI+OQU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Q1auxA5WX/HOw+oFHDr02xSb/z5dUYp1P4qncYzhjXfAp8LNDw3A0RW6rLn2pXtMvbu8vTURRNpYHJYYBHhSzurgDsNP0tPoEmpjzpQcAPRvLaBhIEnX16iov3ZQ/ng5Jlxvk1FK1MfXUSv1K01DkdwB+2SpEibQac5bGMe8WrM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=asPY2b0P; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="asPY2b0P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D7BBC116C6; Tue, 27 Jan 2026 22:10:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769551824; bh=T1bfZ5aiqTQ/sFSevXZf16ujCOKTGhTUPz9xxVI+OQU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=asPY2b0P6PTxKcgn4M/EQv/eeC1mZP3TX0FYuO7SbRXPsYEaEM/LfHs4TtxZSRKZe xDQLyWtCJUluiWJd+ja/iK5bZTl2zLJCDWSLht/9SVQakZyMl1mzjL55OCIyvlMssf G9aHp9VaACCCCysb3hCy/ctc9+ej1Hby4dxXZwxjJC7leJlxqKdyUfzbfEysYyaZVc Y7UlCk3OUwxepQx1YU1F5cD0nUbQT7TeDR8+0psU/AuSN3tsl4Mf5uyxl/ipycliU+ awcN419Rv3urC4pBbrj11ub5xYPS3Zogq9x9jDFIbu8neFnBRsZnPCO4zVuRpF4stI CepEPah88+eXg== Date: Tue, 27 Jan 2026 14:10:22 -0800 From: Drew Fustini To: yunhui cui Cc: Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Radim =?utf-8?B?S3LEjW3DocWZ?= , Samuel Holland , Adrien Ricciardi , Nicolas Pitre , Kornel =?utf-8?Q?Dul=C4=99ba?= , Atish Patra , Atish Kumar Patra , Vasudevan Srinivasan , Ved Shanbhogue , Chen Pei , Liu Zhiwei , Weiwei Li , guo.wenjia23@zte.com.cn, liu.qingtao2@zte.com.cn, Conor Dooley , Krzysztof Kozlowski , Rob Herring , Reinette Chatre , Tony Luck , Babu Moger , Peter Newman , Fenghua Yu , James Morse , Ben Horgan , Dave Martin , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org Subject: Re: [External] [PATCH RFC 08/19] RISC-V: QoS: add resctrl interface for CBQRI controllers Message-ID: References: <20260119-ssqosid-cbqri-v1-0-aa2a75153832@kernel.org> <20260119-ssqosid-cbqri-v1-8-aa2a75153832@kernel.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Mon, Jan 26, 2026 at 01:02:12PM -0800, Drew Fustini wrote: > On Mon, Jan 26, 2026 at 09:01:30PM +0800, yunhui cui wrote: > > Hi Drew, > > > > On Tue, Jan 20, 2026 at 12:15 PM Drew Fustini wrote: > > > > > > Add interface for CBQRI controller drivers to make use of the resctrl > > > filesystem. > > > > > > Co-developed-by: Adrien Ricciardi > > > Signed-off-by: Adrien Ricciardi > > > Signed-off-by: Drew Fustini > > > --- > > > arch/riscv/kernel/qos/qos_resctrl.c | 1191 +++++++++++++++++++++++++++++++++++ > > > 1 file changed, 1191 insertions(+) > > > > > > diff --git a/arch/riscv/kernel/qos/qos_resctrl.c b/arch/riscv/kernel/qos/qos_resctrl.c > > > new file mode 100644 > > > index 000000000000..5e3a65342e9b > > > --- /dev/null > > > +++ b/arch/riscv/kernel/qos/qos_resctrl.c [..] > > > + case RDT_RESOURCE_MBA: > > > + /* Capacity read limit operation for RCID (closid) */ > > > + err = cbqri_bc_alloc_op(ctrl, CBQRI_CC_ALLOC_CTL_OP_READ_LIMIT, closid); > > > + if (err < 0) { > > > + pr_err("%s(): operation failed: err = %d", __func__, err); > > > + return -EIO; > > > + } > > > + > > > + hw_dom->ctrl_val[closid] = cbqri_get_rbwb(ctrl); > > > + > > > + /* Convert from bandwidth blocks to percent */ > > > + rbwb = hw_dom->ctrl_val[closid]; > > > + rbwb *= 100; > > > + percent = rbwb / ctrl->bc.nbwblks; > > > + if (rbwb % ctrl->bc.nbwblks) > > > + percent++; > > > > set: 10, get 11 ? > > The intention was to handle rounding up but I can drop this increment. Actually, this increment of one is necessary. Without it, the default value of 80% will be displayed as 79%. And writing a value like 55% will result in 54%. # mount -t resctrl resctrl /sys/fs/resctrl # cd /sys/fs/resctrl # cat schemata MB:0=79;1=79;2=79 L2:4=fff;5=fff L3:3=ffff # echo 'MB:2=55' > schemata # cat schemata MB:0=79;1=79;2=54 L2:4=fff;5=fff L3:3=ffff # echo 'MB:2=80' > schemata # cat schemata MB:0=79;1=79;2=79 L2:4=fff;5=fff L3:3=ffff Thanks, Drew