All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Fan <peng.fan@oss.nxp.com>
To: Sudeep Holla <sudeep.holla@kernel.org>
Cc: Peng Fan <peng.fan@nxp.com>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Beleswar Padhi <b-padhi@ti.com>, Andrew Davis <afd@ti.com>,
	Yuntao Dai <d1581209858@live.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
	"mailbox@lists.linux.dev" <mailbox@lists.linux.dev>
Subject: Re: [PATCH] mailbox: Clean up the usage of mailbox_client.h
Date: Wed, 28 Jan 2026 15:50:23 +0800	[thread overview]
Message-ID: <aXm/v5KWJf3k7V6a@shlinux89> (raw)
In-Reply-To: <aXjhJzfHvxrP-zc7@bogus>

On Tue, Jan 27, 2026 at 04:00:39PM +0000, Sudeep Holla wrote:
>On Tue, Jan 27, 2026 at 02:47:33PM +0000, Peng Fan wrote:
[...]
>> > > >  #include <linux/mailbox_controller.h> -#include
>> > > > <linux/mailbox_client.h>  #include <linux/io-64-nonatomic-lo-hi.h>
>> > > > #include <acpi/pcc.h>
>> > > >
>> > >
>> > > There is a call to mbox_bind_client() in pcc.c that is declared in
>> > > linux/mailbox_client.h
>> > 
>> > Thanks for raising this.
>> 
>> Check again.
>> 
>> include/acpi/pcc.h includes mailbox_client.h
>> 
>
>I see, I missed that. I’m fine with removing it, but the commit message
>doesn’t really apply here since it’s getting included anyway. I don’t see
>much point in removing it, but I’m fine either way.

I will remove the change to pcc.c in V2, since this driver uses
mbox_bind_client().

Thanks,
Peng

>-- 
>Regards,
>Sudeep
>

      reply	other threads:[~2026-01-28  7:50 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-26 23:02 [PATCH] mailbox: Clean up the usage of mailbox_client.h Peng Fan (OSS)
2026-01-27 11:14 ` Sudeep Holla
2026-01-27 13:51   ` Peng Fan
2026-01-27 14:47     ` Peng Fan
2026-01-27 16:00       ` Sudeep Holla
2026-01-28  7:50         ` Peng Fan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXm/v5KWJf3k7V6a@shlinux89 \
    --to=peng.fan@oss.nxp.com \
    --cc=afd@ti.com \
    --cc=b-padhi@ti.com \
    --cc=d1581209858@live.com \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mailbox@lists.linux.dev \
    --cc=peng.fan@nxp.com \
    --cc=sudeep.holla@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.