From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Gwendal Grignou <gwendal@chromium.org>
Cc: chrome-platform@lists.linux.dev, Gwendal Grignou <gwendal@google.com>
Subject: Re: [PATCH v3 1/2] platform: chrome: lightbar: Report number of segments
Date: Wed, 28 Jan 2026 05:10:25 +0000 [thread overview]
Message-ID: <aXmaQeTV0oTqi_KB@google.com> (raw)
In-Reply-To: <20260128030259.1703848-1-gwendal@google.com>
On Tue, Jan 27, 2026 at 07:02:58PM -0800, Gwendal Grignou wrote:
> diff --git a/drivers/platform/chrome/cros_ec_lightbar.c b/drivers/platform/chrome/cros_ec_lightbar.c
> index 87634f6921b7..30f3e24c84c0 100644
> --- a/drivers/platform/chrome/cros_ec_lightbar.c
> +++ b/drivers/platform/chrome/cros_ec_lightbar.c
> @@ -119,7 +119,7 @@ static int get_lightbar_version(struct cros_ec_dev *ec,
> param = (struct ec_params_lightbar *)msg->data;
> param->cmd = LIGHTBAR_CMD_VERSION;
> msg->outsize = sizeof(param->cmd);
> - msg->result = sizeof(resp->version);
> + msg->insize = sizeof(resp->version);
> ret = cros_ec_cmd_xfer_status(ec->ec_dev, msg);
> if (ret < 0 && ret != -EINVAL) {
> ret = 0;
The change is independent. Can you move the change to a separate patch so
that we can submit the fix first?
prev parent reply other threads:[~2026-01-28 5:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 3:02 [PATCH v3 1/2] platform: chrome: lightbar: Report number of segments Gwendal Grignou
2026-01-28 3:02 ` [PATCH v3 2/2] platform: chrome: lightbar: Add support for large sequence Gwendal Grignou
2026-01-28 5:10 ` Tzung-Bi Shih
2026-01-28 5:10 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXmaQeTV0oTqi_KB@google.com \
--to=tzungbi@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=gwendal@chromium.org \
--cc=gwendal@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.