From: Simon Horman <horms@kernel.org>
To: Cosmin Ratiu <cratiu@nvidia.com>
Cc: Tariq Toukan <tariqt@nvidia.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"andrew+netdev@lunn.ch" <andrew+netdev@lunn.ch>,
"donald.hunter@gmail.com" <donald.hunter@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"leon@kernel.org" <leon@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"edumazet@google.com" <edumazet@google.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"jiri@resnulli.us" <jiri@resnulli.us>,
"pabeni@redhat.com" <pabeni@redhat.com>,
Jiri Pirko <jiri@nvidia.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
Carolina Jubran <cjubran@nvidia.com>,
Mark Bloch <mbloch@nvidia.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
Saeed Mahameed <saeedm@nvidia.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Gal Pressman <gal@nvidia.com>, Moshe Shemesh <moshe@nvidia.com>,
"krzk@kernel.org" <krzk@kernel.org>
Subject: Re: [PATCH net-next V6 07/14] devlink: Add parent dev to devlink API
Date: Wed, 28 Jan 2026 09:20:58 +0000 [thread overview]
Message-ID: <aXnU-klD1_rHY0D0@horms.kernel.org> (raw)
In-Reply-To: <3a000e6a2fcdfb6dc8d18e24d6ee1e7f9f89bc0e.camel@nvidia.com>
On Tue, Jan 27, 2026 at 02:25:51PM +0000, Cosmin Ratiu wrote:
> On Tue, 2026-01-27 at 13:49 +0000, Simon Horman wrote:
> > On Sun, Jan 25, 2026 at 01:31:56PM +0200, Tariq Toukan wrote:
> > > From: Cosmin Ratiu <cratiu@nvidia.com>
...
Hi Cosmin,
> Hi Simon,
>
> We had this conversation during v4, I replied then [1].
Sorry, I had forgotten about that.
> But thinking about it a bit more, I think it's indeed slightly cleaner
> to move the policy and the new pre/post doit handlers to the next
> patch, where they are actually used. The only bit is that the policy is
> used from devlink_get_parent_from_attrs_lock from this function, but it
> appears safe to use NULL there until next patch (the underlying parse
> functions tolerate NULL policies).
>
> So I'll do that in the next submission.
Thanks, that makes sense.
And I'll try to remember this conversation when looking at the next version :)
>
> [1]
> https://lore.kernel.org/netdev/3ec956ea1d0a1c6e56865b2ded6d83ed773ccd4d.camel@nvidia.com/
next prev parent reply other threads:[~2026-01-28 9:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-25 11:31 [PATCH net-next V6 00/14] devlink and mlx5: Support cross-function rate scheduling Tariq Toukan
2026-01-25 11:31 ` [PATCH net-next V6 01/14] documentation: networking: add shared devlink documentation Tariq Toukan
2026-01-27 13:32 ` [net-next,V6,01/14] " Simon Horman
2026-01-25 11:31 ` [PATCH net-next V6 02/14] devlink: introduce shared devlink instance for PFs on same chip Tariq Toukan
2026-01-25 11:31 ` [PATCH net-next V6 03/14] devlink: Reverse locking order for nested instances Tariq Toukan
2026-01-25 11:31 ` [PATCH net-next V6 04/14] devlink: Add helpers to lock nested-in instances Tariq Toukan
2026-01-25 11:31 ` [PATCH net-next V6 05/14] devlink: Refactor devlink_rate_nodes_check Tariq Toukan
2026-01-25 11:31 ` [PATCH net-next V6 06/14] devlink: Decouple rate storage from associated devlink object Tariq Toukan
2026-01-25 11:31 ` [PATCH net-next V6 07/14] devlink: Add parent dev to devlink API Tariq Toukan
2026-01-27 13:49 ` Simon Horman
2026-01-27 14:25 ` Cosmin Ratiu
2026-01-28 9:20 ` Simon Horman [this message]
2026-01-25 11:31 ` [PATCH net-next V6 08/14] devlink: Allow parent dev for rate-set and rate-new Tariq Toukan
2026-01-25 11:31 ` [PATCH net-next V6 09/14] devlink: Allow rate node parents from other devlinks Tariq Toukan
2026-01-25 11:31 ` [PATCH net-next V6 10/14] net/mlx5: Add a shared devlink instance for PFs on same chip Tariq Toukan
2026-01-25 11:32 ` [PATCH net-next V6 11/14] net/mlx5: Expose a function to clear a vport's parent Tariq Toukan
2026-01-25 11:32 ` [PATCH net-next V6 12/14] net/mlx5: Store QoS sched nodes in the sh_devlink Tariq Toukan
2026-01-25 11:32 ` [PATCH net-next V6 13/14] net/mlx5: qos: Support cross-device tx scheduling Tariq Toukan
2026-01-25 11:32 ` [PATCH net-next V6 14/14] net/mlx5: Document devlink rates Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXnU-klD1_rHY0D0@horms.kernel.org \
--to=horms@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=corbet@lwn.net \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=donald.hunter@gmail.com \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jiri@nvidia.com \
--cc=jiri@resnulli.us \
--cc=krzk@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rdunlap@infradead.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.