All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas@wunner.de>
To: Atharva Tiwari <atharvatiwarilinuxdev@gmail.com>
Cc: Ard Biesheuvel <ardb@kernel.org>,
	Jani Nikula <jani.nikula@linux.intel.com>,
	Rodrigo Vivi <rodrigo.vivi@intel.com>,
	Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
	Tvrtko Ursulin <tursulin@ursulin.net>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	Javier Martinez Canillas <javierm@redhat.com>,
	"Borislav Petkov (AMD)" <bp@alien8.de>,
	Lenny Szubowicz <lszubowi@redhat.com>,
	Francesco Pompo <francescopompo2@gmail.com>,
	linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org,
	intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 2/2] drm/i915/display: Disable display for iMac's
Date: Wed, 28 Jan 2026 16:49:05 +0100	[thread overview]
Message-ID: <aXov8c4RSs2f7yAL@wunner.de> (raw)
In-Reply-To: <20260128145855.1071-3-atharvatiwarilinuxdev@gmail.com>

On Wed, Jan 28, 2026 at 02:58:38PM +0000, Atharva Tiwari wrote:
> Disable display on iMacs, as they can't do link training
> on the internal display.
> 
> (tested on iMac20,1)

So with your patch the screen is black on those iMacs?
I don't quite understand why that would be desirable.

What happens without this patch?  Something worse than a black screen?
This needs to be explained in the commit message so that reviewers
understand why the patch is needed.

I also don't understand why this patch follows the EFI set_os one.
What's the connection between those two patches?  If there is none,
they shouldn't be submitted as a series but as two individual patches.

Thanks,

Lukas

  parent reply	other threads:[~2026-01-28 15:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28 14:58 [PATCH v2 0/2] Add support for eGPUs on Apple Products Atharva Tiwari
2026-01-28 14:58 ` [PATCH v2 1/2] efi/libstub: enable apple-set-os for all apple devices Atharva Tiwari
2026-01-28 15:45   ` Lukas Wunner
2026-01-29  4:37     ` Atharva Tiwari
2026-01-29 10:33       ` Lukas Wunner
2026-01-29 17:53         ` Atharva Tiwari
2026-02-02  8:01     ` Atharva Tiwari
2026-01-28 14:58 ` [PATCH v2 2/2] drm/i915/display: Disable display for iMac's Atharva Tiwari
2026-01-28 15:23   ` Jani Nikula
2026-01-28 15:37     ` Ville Syrjälä
2026-01-28 16:03       ` Lukas Wunner
2026-01-28 15:49   ` Lukas Wunner [this message]
2026-01-28 15:56 ` [PATCH v2 0/2] Add support for eGPUs on Apple Products Lukas Wunner
2026-01-28 17:12   ` Atharva Tiwari
2026-01-29 21:00 ` ✗ LGCI.VerificationFailed: failure for Add support for eGPUs on Apple Products (rev2) Patchwork
2026-01-29 21:02 ` Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aXov8c4RSs2f7yAL@wunner.de \
    --to=lukas@wunner.de \
    --cc=airlied@gmail.com \
    --cc=ardb@kernel.org \
    --cc=atharvatiwarilinuxdev@gmail.com \
    --cc=bp@alien8.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=francescopompo2@gmail.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=javierm@redhat.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=linux-efi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lszubowi@redhat.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=simona@ffwll.ch \
    --cc=tursulin@ursulin.net \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.