From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Minu Jin <s9430939@naver.com>
Cc: gregkh@linuxfoundation.org, hansg@kernel.org,
dan.carpenter@linaro.org, trohan2000@gmail.com, andy@kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
straube.linux@gmail.com
Subject: Re: [PATCH v3 3/4] staging: rtl8723bs: replace skb allocation wrappers and fix build
Date: Thu, 29 Jan 2026 00:04:51 +0200 [thread overview]
Message-ID: <aXqIAzZBIx04GTOJ@smile.fi.intel.com> (raw)
In-Reply-To: <20260128140954.1065382-4-s9430939@naver.com>
On Wed, Jan 28, 2026 at 11:09:53PM +0900, Minu Jin wrote:
> Replace the wrapper functions rtw_skb_alloc and rtw_skb_copy with
> kernel APIs __dev_alloc_skb and skb_copy.
We refer to the functions as func() (note the parentheses).
...
> Additionally, this patch restores the definitions of _rtw_malloc and
> _rtw_zmalloc that were prematurely removed in previous commits.
Huh?! Don't remove them if driver doesn't compile.
> This ensures that the driver remains buildable, fixing git bisect issues
> until all wrappers are fully migrated and can be safely removed in
> the final cleanup step.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-28 22:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 14:09 [PATCH v3 0/4] staging: rtl8723bs: remove memory allocation wrappers Minu Jin
2026-01-28 14:09 ` [PATCH v3 1/4] staging: rtl8723bs: replace _rtw_malloc with kmalloc Minu Jin
2026-01-28 21:51 ` Andy Shevchenko
2026-01-28 21:52 ` Andy Shevchenko
2026-01-28 14:09 ` [PATCH v3 2/4] staging: rtl8723bs: replace rtw_zmalloc with kzalloc Minu Jin
2026-01-28 22:02 ` Andy Shevchenko
2026-01-28 14:09 ` [PATCH v3 3/4] staging: rtl8723bs: replace skb allocation wrappers and fix build Minu Jin
2026-01-28 22:04 ` Andy Shevchenko [this message]
2026-01-28 14:09 ` [PATCH v3 4/4] staging: rtl8723bs: remove unused allocation wrapper functions Minu Jin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXqIAzZBIx04GTOJ@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=s9430939@naver.com \
--cc=straube.linux@gmail.com \
--cc=trohan2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.