From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Menderes Sabaz <sabazmenderes@gmail.com>
Cc: linux-iio@vger.kernel.org, lars@metafoo.de,
Michael.Hennerich@analog.com, jic23@kernel.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org
Subject: Re: [PATCH] iio: dac: ad5360: converting to guard(mutex)
Date: Thu, 29 Jan 2026 12:54:38 +0200 [thread overview]
Message-ID: <aXs8brEx7EAcmpEQ@smile.fi.intel.com> (raw)
In-Reply-To: <20260128231419.415390-1-sabazmenderes@gmail.com>
On Thu, Jan 29, 2026 at 02:14:19AM +0300, Menderes Sabaz wrote:
> Converting mutex_lock and mutex_unlock to guard(mutex)
Refer to the functions as func() and don't forget period at the end.
Converting mutex_lock() and mutex_unlock() to guard(mutex)().
...
> + return ad5360_write_unlocked(indio_dev, AD5360_CMD_SPECIAL_FUNCTION,
> + AD5360_REG_SF_CTRL, st->ctrl, 0);
Wrong indentation.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-01-29 10:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 11:37 [PATCH] iio: dac: ad5360: convert to guard(mutex) Menderes Sabaz
2026-01-28 14:54 ` David Lechner
2026-01-28 15:32 ` [PATCH v2] " Menderes Sabaz
2026-01-28 22:32 ` Andy Shevchenko
2026-01-28 22:47 ` David Lechner
2026-01-28 23:14 ` [PATCH] iio: dac: ad5360: converting " Menderes Sabaz
2026-01-29 10:54 ` Andy Shevchenko [this message]
2026-01-29 16:16 ` [PATCH v2] iio: dac: ad5360: convert " Jonathan Cameron
2026-01-29 16:18 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2026-01-29 11:37 [PATCH] iio: dac: ad5360: converting " Menderes Sabaz
2026-01-29 14:38 ` David Lechner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXs8brEx7EAcmpEQ@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sabazmenderes@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.