From: Cyril Hrubis <chrubis@suse.cz>
To: Li Wang <liwang@redhat.com>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH 1/1] doc/ground_rules: Add Kernel features check rules
Date: Thu, 29 Jan 2026 09:59:19 +0100 [thread overview]
Message-ID: <aXshZzXAG8L0GFEC@rei.lan> (raw)
In-Reply-To: <CAEemH2fc_C_vGnKtbYqsMzMVKLSNLhCFWLGemSyVTWBzAATDCA@mail.gmail.com>
Hi!
> > I wonder how about .needs_kconfigs vs. needs_drivers. Do we prefer any of these?
> > I suppose the rule could be .needs_drivers when nothing specific from module is
> > needed, .needs_kconfigs otherwise.
>
> Hmm, this looks only belongs to the second section.
> Maybe:
>
> - Tristate/module feature: If the functionality is controlled by a Kconfig of
> type tristate (`tristate
> <https://docs.kernel.org/kbuild/kconfig-language.html#menu-attributes>`_),
> it might be built as a module. Modules can be absent or unloaded
> at runtime,
> so checking the Kconfig option alone isn’t enough. Instead of
> .needs_kconfigs,
> rely on .needs_drivers or a runtime check to confirm the module is loaded.
Sounds good to me.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
next prev parent reply other threads:[~2026-01-29 9:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-28 8:01 [LTP] [PATCH 1/1] doc/ground_rules: Add Kernel features check rules Petr Vorel
2026-01-28 9:00 ` Li Wang via ltp
2026-01-28 12:45 ` Petr Vorel
2026-01-28 20:50 ` Petr Vorel
2026-01-29 7:24 ` Li Wang via ltp
2026-01-29 8:59 ` Cyril Hrubis [this message]
2026-02-11 13:05 ` Andrea Cervesato via ltp
2026-03-11 9:12 ` Petr Vorel
2026-03-11 9:15 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXshZzXAG8L0GFEC@rei.lan \
--to=chrubis@suse.cz \
--cc=liwang@redhat.com \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.