From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jakub Kicinski <kuba@kernel.org>
Cc: andrew@lunn.ch, hkallweit1@gmail.com,
florian.fainelli@broadcom.com, xiaolei.wang@windriver.com,
Wei Fang <wei.fang@nxp.com>,
davem@davemloft.net, edumazet@google.com, pabeni@redhat.com,
maxime.chevallier@bootlin.com, quic_abchauha@quicinc.com,
quic_sarohasa@quicinc.com, imx@lists.linux.dev,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: phy: add device link between MAC device and MDIO device
Date: Thu, 29 Jan 2026 10:06:29 +0000 [thread overview]
Message-ID: <aXsxJa0D0bohafRs@shell.armlinux.org.uk> (raw)
In-Reply-To: <20260128201501.04bb6e5c@kernel.org>
On Wed, Jan 28, 2026 at 08:15:01PM -0800, Jakub Kicinski wrote:
> On Mon, 26 Jan 2026 18:44:09 +0800 Wei Fang wrote:
> > The commit bc66fa87d4fd ("net: phy: Add link between phy dev and mac
> > dev") has created a device link between the MAC and the PHY if the MAC
> > uses a shared MDIO bus (The MDIO and the MAC are two separate devices).
> > Sarosh Hasan tried to change the DL_FLAG_STATELESS flag to
> > DL_FLAG_AUTOREMOVE_SUPPLIER to fix the issue [1]. However, the solution
> > does not take into account the hot-swappable PHY devices (such as SFP).
> > so when the PHY device is unplugged, the MAC driver will automatically
> > be removed, which is not the expected behavior.
> >
> > Therefore, to solve this issue of the shared MDIO bus, we create the
> > device link between the MAC device and the MDIO device, rather than
> > between the MAC device and the PHY device. And when the shared MDIO bus
> > is removed, all MAC drivers that depend on it will also be removed.
>
> Anyone willing to venture a review tag?
No, I don't agrew with the patch.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2026-01-29 10:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 10:44 [PATCH net] net: phy: add device link between MAC device and MDIO device Wei Fang
2026-01-26 14:13 ` Andrew Lunn
2026-01-26 14:19 ` Russell King (Oracle)
2026-01-27 3:01 ` Wei Fang
2026-01-29 4:15 ` Jakub Kicinski
2026-01-29 10:06 ` Russell King (Oracle) [this message]
2026-01-30 3:41 ` Wei Fang
2026-01-30 8:29 ` Maxime Chevallier
2026-01-30 8:45 ` Wei Fang
2026-01-30 9:12 ` Maxime Chevallier
2026-01-30 10:09 ` Wei Fang
2026-01-29 9:10 ` Maxime Chevallier
2026-01-29 10:00 ` Wei Fang
2026-01-29 10:18 ` Maxime Chevallier
2026-01-29 10:47 ` Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXsxJa0D0bohafRs@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=hkallweit1@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_abchauha@quicinc.com \
--cc=quic_sarohasa@quicinc.com \
--cc=wei.fang@nxp.com \
--cc=xiaolei.wang@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.