From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0ACACD49C77 for ; Fri, 30 Jan 2026 08:34:41 +0000 (UTC) Received: from kara.freedesktop.org (unknown [131.252.210.166]) by gabe.freedesktop.org (Postfix) with ESMTPS id D160110E946; Fri, 30 Jan 2026 08:34:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="m7/9ZJIe"; dkim-atps=neutral Received: from kara.freedesktop.org (localhost [127.0.0.1]) by kara.freedesktop.org (Postfix) with ESMTP id 9B4C140F37; Fri, 30 Jan 2026 08:25:34 +0000 (UTC) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=lists.freedesktop.org; s=20240201; t=1769761534; b=ToCu1mdTsrCAFzfifxV9U0opBmxyQpXcvxUWP1ufp8WHY8temuvqeGLu3Ys800Z6mWekU oovWMpfsUPRrCOhEyfV0jDs2N012nPxHyNgcAZ8y/VmT9lEsUbuD1SjRZDbZO0Ipp+fxNa/ FrxZ/2ewClQisNNDR1bw7aosii3KhYjPiIfU3CU4ArkwERfPuYm3xK8nbsykS3e0kA9OX3c N4+8E0EuxXPcj3Nbj+k0LtuRFEB7dRgVj5KmceyKovqM5uv3AnJacQdLVH33bcNeDzdzObz 2zdOG47oiWhFrnN7B7RIdgAfsHH5PS24KeUfIOu2jEX6tV1UZfN6Axnp/GrQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=lists.freedesktop.org; s=20240201; t=1769761534; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=BXwrLkuO838vdnUICThk+ZOtuk7JQw/6t67kS9o7Wo0=; b=0Ck2puGjujrEn4ILetbuYpxUKQ88j5LrdyJxB/qPrvDvbQvByqbV4eP4qg/BbxjCUOfPJ 1367mrvkO439FohyceGu16B5bjKvJF2KfxbhTFoQ8ygUPSXtyGTMJAfTFO6fsG+L93E6t+B /Nf+gQm6HfB+vCU6TzI8Ds55AO1G29xlL2wKPeeve2BMS93+7q4MutP5RY+fDaNi36vRnBe iATqnzlPJ+c3QSW9OXc0HWjrJ85qt9rOtOplMlvilwjcDAW4ZNKlCTO+/Gv2Yr65lVUC4wO B6KvvREq4pyrzxpraq0bXYWQh9AWC2EvdwqrSrswbGkn5icyIN3m1rsdacjA== ARC-Authentication-Results: i=1; mail.freedesktop.org; dkim=pass header.d=google.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=google.com policy.dmarc=reject Authentication-Results: mail.freedesktop.org; dkim=pass header.d=google.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=google.com policy.dmarc=reject Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by kara.freedesktop.org (Postfix) with ESMTPS id 73FD940ACE for ; Fri, 30 Jan 2026 08:25:31 +0000 (UTC) Received: from mail-ej1-f74.google.com (mail-ej1-f74.google.com [209.85.218.74]) by gabe.freedesktop.org (Postfix) with ESMTPS id 740AA10E92F for ; Fri, 30 Jan 2026 08:34:37 +0000 (UTC) Received: by mail-ej1-f74.google.com with SMTP id a640c23a62f3a-b8704795d25so254145166b.2 for ; Fri, 30 Jan 2026 00:34:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769762076; x=1770366876; darn=lists.freedesktop.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=BXwrLkuO838vdnUICThk+ZOtuk7JQw/6t67kS9o7Wo0=; b=m7/9ZJIeOBBAPoVQGUsO6gkY0OCEbrCpNM0/Jy6hzpU1deMQox9eBQnP8kfKf+iixW QL0BdmloU20K6kAf1qo8j6z5QyUTLDeXPYUfRIX8/QrskyPNg1yjT+KXSUp2k1VICmXM ma3v6VV1JwEgEV9bh6qnI1TU8GQ9G4xmohOCKVkjm0N7ZbcHUD9j3dWdPS63ZR+ffXO4 X4Md47hMLDidpCfY5fhfejkMUK6LNqDfag6IO+QDyX84pd5SWCVZBoOc+tXdbLO+yAx7 vlRyurlhepK2J1HVvlg7WMXacxNREJfdET6vi9M6EWlgy4KXU2w416rpXoRZjTyDZdbU dw0w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769762076; x=1770366876; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BXwrLkuO838vdnUICThk+ZOtuk7JQw/6t67kS9o7Wo0=; b=cLbzgIMcUjvEue2is3Bik83+DUPYlX+or4JV0Y1xipMPJ1mFchv+5WQWbbDTBRfUWU a97mbKRanA6u3NyjglCxYI7N7cfb4vbUI22NHlE8Ld5+Qc4jgDgNuRvgrNuWP7fMhojq oFfBQEgDWudzk7w6HsG6H6xFCbL0cq9xAML0EjzBd+mNBG44rsdky178CqaUBvnzrimK hGGLlPU+a3j2LwQ4XFSprw72nW8Pjhlfi/L42b+DKPNmLgESe4OvyajG5yhLRfgowNHR zgMQKLjnczumT1CbbLxmYvB+t0IfstbUI3F3InBaVcOBs9xX0GhVPru+JmW9/vwRpbxn xH3g== X-Forwarded-Encrypted: i=1; AJvYcCUMQ0+lnWJNgKyLr1UDtteMUbyhw0UGpinIfuuGMZlkYDHAXgmaoi1Y4/1/MLC7xVXRtlOdTJCF@lists.freedesktop.org X-Gm-Message-State: AOJu0YyGq5GvfjveVt8vgP/xjWqEUBj0ar7QxYG4ciS4QQODhl6ILMuY jAp4p7apTHJht0eEW8OIh4ej5EFDJBbHS2jrsoUh9H08LYKyRHc+W0c2LmzzrLdOTk3Zsv+KlUC O+Hc1oFaYgVruGHjXEg== X-Received: from ejbot14.prod.google.com ([2002:a17:906:ccce:b0:b7d:380b:a83c]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a17:907:9287:b0:b87:1fe6:f223 with SMTP id a640c23a62f3a-b8dff5e8fecmr102609966b.6.1769762075992; Fri, 30 Jan 2026 00:34:35 -0800 (PST) Date: Fri, 30 Jan 2026 08:34:35 +0000 In-Reply-To: <20260129022837.4133832-7-ttabi@nvidia.com> Mime-Version: 1.0 References: <20260129022837.4133832-1-ttabi@nvidia.com> <20260129022837.4133832-7-ttabi@nvidia.com> Message-ID: Subject: Re: [PATCH v6 6/7] gpu: nova-core: create debugfs root in module init From: Alice Ryhl To: Timur Tabi Content-Type: text/plain; charset="utf-8" Message-ID-Hash: 3VEM3SHKELS2XKQFHQ5FITJBYN7GTXFJ X-Message-ID-Hash: 3VEM3SHKELS2XKQFHQ5FITJBYN7GTXFJ X-MailFrom: 3G218aQkKBzoWheYanudhckkcha.YkijkqraWqheopo.bnaaZaogpkl.knc@flex--aliceryhl.bounces.google.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Gary Guo , mmaurer@google.com, Danilo Krummrich , Alexandre Courbot , Joel Fernandes , nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: Nouveau development list Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Jan 28, 2026 at 08:28:36PM -0600, Timur Tabi wrote: > +// FIXME: Move this into per-module data once that exists > +static mut DEBUGFS_ROOT: Option = None; Surely debugfs has a solution to avoid this... Alice From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f73.google.com (mail-ej1-f73.google.com [209.85.218.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCA452DECCB for ; Fri, 30 Jan 2026 08:34:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769762079; cv=none; b=Mk26KtT1wbyIfY0PVhaDkG0he8/4QMV9VgTm8w50zpLJOrmVNaw564u4UHdzHgM76xHWpV4vOy5kt1TJvfML8JWJ2FCmRayBYNGVAwVofSDfKRBtoUJcZyOcHy1TGwoYlk6XuyHRXE5iunAhsAFRQixZ7zDS2zYF8rnshMn4tMc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769762079; c=relaxed/simple; bh=BXwrLkuO838vdnUICThk+ZOtuk7JQw/6t67kS9o7Wo0=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=IB30h2BxDkRMrbof3kGS1U8GB50wg4HhGKJYcdjngLiyia9NLf/83cPfsxZ+LpMrmejKqSFhIC+yBN5GF+IJPpHptf5uiIV7x9Qt+dzxKRzf43xhzIbSMjhLBsvFSjH5VeDWZjma91azSZ3T0FAPJwQSGCmJXVyLEhL9oXZdbGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=Vqz772fG; arc=none smtp.client-ip=209.85.218.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--aliceryhl.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Vqz772fG" Received: by mail-ej1-f73.google.com with SMTP id a640c23a62f3a-b884bfed5a7so181514766b.0 for ; Fri, 30 Jan 2026 00:34:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1769762076; x=1770366876; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=BXwrLkuO838vdnUICThk+ZOtuk7JQw/6t67kS9o7Wo0=; b=Vqz772fGDp+KpsTekSxBN1rUPUSvVHQVcRSVbcsN2i6dHCGIqMS/i+loJjTN1V1jU5 Jg7rqBcDlkro4f10FgVsMEFkI9IdywY8kBkriMZ5EU+0S7vJ+d2mGhuSYQnZ3CX94FLE Tfwezk4XJn+4iFdYXxpXliQsglKBK7TJOlan31EGqWUzViElaPNOnnNmTsluAQp2p1u3 Cim5igqcjHarOxqm9IJj25vBGekY7bNoXrQIR76lYCady9v+hOTQDqq4Gg6pICvNpg0v 92sZDJ7Ni8Gx9f9W4oJbeZXwjN/45z08chSRVajYRCZjfh+XrTcS9/m62tQxRXN0Jz1G B1CQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769762076; x=1770366876; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BXwrLkuO838vdnUICThk+ZOtuk7JQw/6t67kS9o7Wo0=; b=V40KmcSvBnW1ZXa2goRvvRUChc0q0LPXC00BNrv25ggR68jI0ZC34JZZ3ekw3kdLof 1/xDPgRzL2LECOhKoURfvoVdgRmcIHxP5IvOtUbreUFAF9vC9VfDDnZbDIAPZrtONBKJ y6q/tDUi4cLPJAGs7amnQ9SeIreCeqc1SaL2OzMDSqMB38XdTCjB0QFmDRzwfot+K039 cRXedtol62ZG7TYY8inj8Onb0CRiW3na2QbvGD/D/iMdJnkMAlHJbaTjm/ncuboAHuJU zA8blIjSoLw2yom7QlU44Nx9vy60tGgQFlWCBFE16cCZ3719ppPvrB+MBhxvm3OTv133 98bA== X-Forwarded-Encrypted: i=1; AJvYcCVW/I0w+WFtn/Agm2VViWgNXUqBK4v0SU5U/G9/FkwwLrOXctiJuEF7tU9IVSJtCxelRs6Ia9TsN29MQ6zHAQ==@vger.kernel.org X-Gm-Message-State: AOJu0YxSl3ESc8VpeMbZ5XJ4CeTmHhQTjbolqBrDiFo3RbJM0UQJCUnv n8C/WiXSc0wOm43dkj6RyEN1nXjHSuSMiPzI69OCo/aU9rPzVh8lN2FCwfirHsADs/YEj21m4Sy sFRxzWbmRidx0B/4eEQ== X-Received: from ejbot14.prod.google.com ([2002:a17:906:ccce:b0:b7d:380b:a83c]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a17:907:9287:b0:b87:1fe6:f223 with SMTP id a640c23a62f3a-b8dff5e8fecmr102609966b.6.1769762075992; Fri, 30 Jan 2026 00:34:35 -0800 (PST) Date: Fri, 30 Jan 2026 08:34:35 +0000 In-Reply-To: <20260129022837.4133832-7-ttabi@nvidia.com> Precedence: bulk X-Mailing-List: rust-for-linux@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260129022837.4133832-1-ttabi@nvidia.com> <20260129022837.4133832-7-ttabi@nvidia.com> Message-ID: Subject: Re: [PATCH v6 6/7] gpu: nova-core: create debugfs root in module init From: Alice Ryhl To: Timur Tabi Cc: Gary Guo , mmaurer@google.com, Danilo Krummrich , Alexandre Courbot , John Hubbard , Joel Fernandes , nouveau@lists.freedesktop.org, rust-for-linux@vger.kernel.org Content-Type: text/plain; charset="utf-8" On Wed, Jan 28, 2026 at 08:28:36PM -0600, Timur Tabi wrote: > +// FIXME: Move this into per-module data once that exists > +static mut DEBUGFS_ROOT: Option = None; Surely debugfs has a solution to avoid this... Alice