From: Niklas Cassel <cassel@kernel.org>
To: Koichiro Den <den@valinux.co.jp>
Cc: Aksh Garg <a-garg7@ti.com>,
linux-pci@vger.kernel.org, jingoohan1@gmail.com, mani@kernel.org,
lpieralisi@kernel.org, kwilczynski@kernel.org, robh@kernel.org,
bhelgaas@google.com, Zhiqiang.Hou@nxp.com,
gustavo.pimentel@synopsys.com, linux-kernel@vger.kernel.org,
s-vadapalli@ti.com, danishanwar@ti.com
Subject: Re: [PATCH v4 2/3] PCI: dwc: ep: Add per-PF BAR and inbound ATU mapping support
Date: Fri, 30 Jan 2026 10:57:18 +0100 [thread overview]
Message-ID: <aXyAfilrBOe1cEEk@ryzen> (raw)
In-Reply-To: <s5hd43mnktvnuikuai25fhzchkt4y5w3ejabqhr43ihvwuefb3@wvatfe5k4loe>
On Fri, Jan 30, 2026 at 11:21:32AM +0900, Koichiro Den wrote:
> >
> > Koichiro (he is on To:),
> >
> > don't you think that it would be clearer if we had a:
> > return;
> >
> > here...
> >
> > I mean, a BAR can either have a BAR match mode mapping or a subrange mapping,
> > but not both... So continuing executing code beyond this point seems pointless,
> > possibly even confusing.
>
> Thanks for pinging. I agree it would be clearer. Since it's orthogonal to
> this series, would it be better if I sent a one-line patch?
Thank you Koichiro, I think a one liner patch for this would be nice.
You can also write in the changelog (after the ----) that Mani can squash
your one liner patch into the existing submap commit if he wants.
Kind regards,
Niklas
next prev parent reply other threads:[~2026-01-30 9:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 9:17 [PATCH v4 0/3] PCI: dwc: ep: Enhance multi-function endpoint support Aksh Garg
2026-01-29 9:17 ` [PATCH v4 1/3] PCI: dwc: ep: Fix resizable BAR support for multi-PF configurations Aksh Garg
2026-01-29 9:17 ` [PATCH v4 2/3] PCI: dwc: ep: Add per-PF BAR and inbound ATU mapping support Aksh Garg
2026-01-29 14:14 ` Niklas Cassel
2026-01-30 2:21 ` Koichiro Den
2026-01-30 9:57 ` Niklas Cassel [this message]
2026-01-30 17:16 ` Koichiro Den
2026-01-30 22:51 ` Niklas Cassel
2026-01-31 13:42 ` Koichiro Den
2026-01-30 4:12 ` Aksh Garg
2026-01-30 9:53 ` Niklas Cassel
2026-01-30 10:39 ` Aksh Garg
2026-01-30 10:47 ` Niklas Cassel
2026-01-30 10:52 ` Aksh Garg
2026-01-29 9:17 ` [PATCH v4 3/3] PCI: dwc: ep: Add comment explaining controller-level PTM access Aksh Garg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aXyAfilrBOe1cEEk@ryzen \
--to=cassel@kernel.org \
--cc=Zhiqiang.Hou@nxp.com \
--cc=a-garg7@ti.com \
--cc=bhelgaas@google.com \
--cc=danishanwar@ti.com \
--cc=den@valinux.co.jp \
--cc=gustavo.pimentel@synopsys.com \
--cc=jingoohan1@gmail.com \
--cc=kwilczynski@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.