All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zhao Liu <zhao1.liu@intel.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Eduardo Habkost <eduardo@habkost.net>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Richard Henderson <richard.henderson@linaro.org>,
	Pierrick Bouvier <pierrick.bouvier@linaro.org>
Subject: Re: [PATCH] docs: simplify DiamondRapids CPU docs
Date: Thu, 12 Feb 2026 10:30:56 +0800	[thread overview]
Message-ID: <aY07YNr9/RvKn3nF@intel.com> (raw)
In-Reply-To: <20260211180021.1057478-1-berrange@redhat.com>

On Wed, Feb 11, 2026 at 06:00:21PM +0000, Daniel P. Berrangé wrote:
> Date: Wed, 11 Feb 2026 18:00:21 +0000
> From: "Daniel P. Berrangé" <berrange@redhat.com>
> Subject: [PATCH] docs: simplify DiamondRapids CPU docs
> 
> This aligns the first line of the docs with the style used for previous
> CPU models, and simplifies the text in the remaining docs.
> 
> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>
> ---
>  docs/system/cpu-models-x86.rst.inc | 16 ++++++----------
>  1 file changed, 6 insertions(+), 10 deletions(-)
> 
> diff --git a/docs/system/cpu-models-x86.rst.inc b/docs/system/cpu-models-x86.rst.inc
> index 3605d05a8c..9d4486c978 100644
> --- a/docs/system/cpu-models-x86.rst.inc
> +++ b/docs/system/cpu-models-x86.rst.inc
> @@ -72,17 +72,13 @@ compatibility is required, use the newest CPU model that is compatible
>  across all desired hosts.
>  
>  ``DiamondRapids``
> -    Intel Xeon Processor.
> +    Intel Xeon Processor (DiamondRapids, 2025)

Maybe 2026? I think the year should be the release data instead of patch
data.

> -    Diamond Rapids product has a topology which differs from previous Xeon
> -    products. It does not support SMT, but instead features a dual core
> -    module (DCM) architecture. It also has core building blocks (CBB - die
> -    level in CPU topology). The cache hierarchy is organized as follows:
> -    L1 i/d cache is per thread, L2 cache is per DCM, and L3 cache is per
> -    CBB. This cache topology can be emulated for DiamondRapids CPU model
> -    using the smp-cache configuration as shown below:
> -
> -    Example:
> +    This does not include SMT but allows the module (dual core module
> +    - DCM) and die (core building block - CBB) topology levels. The
> +    cache hierarchy is L1 i/d cache per thread, L2 cache per module,
> +    and L3 cache per die, which can be emulated using the smp-cache
> +    option:

Otherwise, look good to me, and thanks!

Reviewed-by: Zhao Liu <zhao1.liu@intel.com>

Regards,
Zhao



  parent reply	other threads:[~2026-02-12  2:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11 18:00 [PATCH] docs: simplify DiamondRapids CPU docs Daniel P. Berrangé
2026-02-11 18:36 ` Pierrick Bouvier
2026-02-11 18:44   ` Daniel P. Berrangé
2026-02-11 19:09     ` Pierrick Bouvier
2026-02-12  2:30 ` Zhao Liu [this message]
2026-02-12  8:04   ` Daniel P. Berrangé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aY07YNr9/RvKn3nF@intel.com \
    --to=zhao1.liu@intel.com \
    --cc=berrange@redhat.com \
    --cc=eduardo@habkost.net \
    --cc=pbonzini@redhat.com \
    --cc=pierrick.bouvier@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.