From: Richard Acayan <mailingradian@gmail.com>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Cc: Lee Jones <lee@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Amit Kucheria <amitk@kernel.org>,
Thara Gopinath <thara.gopinath@gmail.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Stephen Boyd <sboyd@kernel.org>,
Dmitry Baryshkov <lumag@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-pm@vger.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: pm660: add thermal monitor
Date: Thu, 12 Feb 2026 13:27:59 -0500 [thread overview]
Message-ID: <aY4br1BX9InqWUd6@rdacayan> (raw)
In-Reply-To: <f1fc24ad-054f-4731-b982-4c579abf46c1@oss.qualcomm.com>
On Thu, Feb 12, 2026 at 01:15:04PM +0100, Konrad Dybcio wrote:
> On 2/11/26 1:29 AM, Richard Acayan wrote:
> > On Tue, Feb 10, 2026 at 10:59:20AM +0100, Konrad Dybcio wrote:
> >> On 2/10/26 3:18 AM, Richard Acayan wrote:
> > (snip)
> >>> + pm660_adc_tm: adc-tm@3400 {
> >>> + compatible = "qcom,spmi-adc-tm-hc";
> >>> + reg = <0x3400>;
> >>> + interrupts = <0x0 0x34 0x0 IRQ_TYPE_EDGE_RISING>;
> >>> + #thermal-sensor-cells = <1>;
> >>> + #address-cells = <1>;
> >>> + #size-cells = <0>;
> >>> + status = "disabled";
> >>
> >> Can we enable it by default?
> >
> > No, the thermal monitor fails to probe if it doesn't have any channels:
> >
> > [ 17.728926] qcom-spmi-adc-tm5 c440000.spmi:pmic@0:adc-tm@3400: error -EINVAL: get dt data failed
> > [ 17.728945] qcom-spmi-adc-tm5 c440000.spmi:pmic@0:adc-tm@3400: probe with driver qcom-spmi-adc-tm5 failed with error -22
> >
> > Triggered by https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/thermal/qcom/qcom-spmi-adc-tm5.c?h=next-20260209#n945
>
> You can define the following ones in the common dt:
>
> REF_GND
Is there any (likely passive, if any) cooling device that should be
activated when this goes above or below a certain reading?
> 1.25VREF
> VREF_VADC
> VPH_PWR
> VCOIN
> DIE_TEMP
Maybe this temperature can be included, but I don't see any other
PMIC devicetree that has this channel ready-to-go.
> ANA_IN
next prev parent reply other threads:[~2026-02-12 18:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-10 2:18 [PATCH 0/3] Thermal monitor on PM660 Richard Acayan
2026-02-10 2:18 ` [PATCH 1/3] dt-bindings: mfd: qcom,spmi-pmic: Allow PMIC4 thermal monitor on pm660 Richard Acayan
2026-02-10 9:56 ` Konrad Dybcio
2026-02-11 6:44 ` Krzysztof Kozlowski
2026-02-10 2:18 ` [PATCH 2/3] thermal: qcom-spmi-adc-tm5: Correct the voltage-code scaling for HC Richard Acayan
2026-02-10 9:58 ` Konrad Dybcio
2026-02-11 2:09 ` Dmitry Baryshkov
2026-02-10 2:18 ` [PATCH 3/3] arm64: dts: qcom: pm660: add thermal monitor Richard Acayan
2026-02-10 9:59 ` Konrad Dybcio
2026-02-11 0:29 ` Richard Acayan
2026-02-12 12:15 ` Konrad Dybcio
2026-02-12 18:27 ` Richard Acayan [this message]
2026-02-16 11:58 ` Konrad Dybcio
2026-03-03 2:25 ` Richard Acayan
2026-04-15 9:15 ` Konrad Dybcio
2026-04-15 21:05 ` Richard Acayan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aY4br1BX9InqWUd6@rdacayan \
--to=mailingradian@gmail.com \
--cc=amitk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=lumag@kernel.org \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sboyd@kernel.org \
--cc=thara.gopinath@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.