All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@gnu.org>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com
Subject: Re: [PATCH] baum: Add copy/paste bindings
Date: Fri, 13 Feb 2026 01:08:33 +0100	[thread overview]
Message-ID: <aY5rgfbOQvtc5ECm@end> (raw)
In-Reply-To: <CAJ+F1CKZUz6QDDYj9g2NeyKimOrcXDN-ZYG12CYg2pJn9s4Hjw@mail.gmail.com>

Marc-André Lureau, le jeu. 12 févr. 2026 13:43:01 +0400, a ecrit:
> On Wed, Feb 11, 2026 at 9:46 PM Samuel Thibault
> <samuel.thibault@ens-lyon.org> wrote:
> 
> Can you write a summary of how this work,

I have added comments.

> where the protocol is documented.

Braille protocols are essentially never documented publicly. All that is
publicly available. is from the free brltty driver implementation

> Also higher-level doc for changelog would be nice.

I'm not sure what more would be useful: it's mere addition key binding.

> > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> > ---
> >  chardev/baum.c | 30 +++++++++++++++++++++++++++++-
> >  1 file changed, 29 insertions(+), 1 deletion(-)
> >
> > +            case BRLAPI_KEY_CMD_CLIP_NEW:
> > +                baum_send_key(baum, BAUM_RSP_TopKeys, BAUM_TL1);
> > +                baum_send_key(baum, BAUM_RSP_RoutingKey, (code & BRLAPI_KEY_CMD_ARG_MASK)+1);
> > +                baum_send_key(baum, BAUM_RSP_RoutingKey, 0);
> > +                baum_send_key(baum, BAUM_RSP_TopKeys, 0);
> > +                break;
> > --
> 
> Those commands date back from brltty 4.4 (June 7, 2012). I suggest we
> add a version check to the brlapi dependency.

That is so old that I didn't even remember that they had changed.

Samuel


      parent reply	other threads:[~2026-02-13  0:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-11 20:44 [PATCH] baum: Add copy/paste bindings Samuel Thibault
2026-02-12  9:43 ` Marc-André Lureau
2026-02-12 10:33   ` Peter Maydell
2026-02-12 11:02     ` Daniel P. Berrangé
2026-02-13  0:09       ` Samuel Thibault
2026-02-13  8:09         ` Daniel P. Berrangé
2026-02-13 11:55           ` Samuel Thibault
2026-02-13  0:08   ` Samuel Thibault [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aY5rgfbOQvtc5ECm@end \
    --to=samuel.thibault@gnu.org \
    --cc=marcandre.lureau@gmail.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.