All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Cc: Zorro Lang <zlang@redhat.com>,
	linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
	linux-xfs@vger.kernel.org
Subject: Re: [PATCH 1/2] fstests: add _fixed_by_fs_commit helper
Date: Thu, 12 Feb 2026 23:13:12 -0800	[thread overview]
Message-ID: <aY7PCGwxpwxx90yW@infradead.org> (raw)
In-Reply-To: <20260213070148.37518-2-johannes.thumshirn@wdc.com>

On Fri, Feb 13, 2026 at 08:01:47AM +0100, Johannes Thumshirn wrote:
> +	local fstyp=$1
> +	shift
> +
> +	[ "$fstyp" = "$FSTYP" ] && \
> +		_fixed_by_kernel_commit $*
> +}

Minor nit, but this looks a bit odd to me.  I usually prefer the
full blown if:

	if [ "$fstyp" = "$FSTYP" ]; then
		_fixed_by_kernel_commit $*
	fi

but if you want to short cut it, just put it all on a single line:

	[ "$fstyp" = "$FSTYP" ] && _fixed_by_kernel_commit $*

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>

  reply	other threads:[~2026-02-13  7:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13  7:01 [PATCH 0/2] fstests: simplify per-fs _fixed_by_kernel_commit Johannes Thumshirn
2026-02-13  7:01 ` [PATCH 1/2] fstests: add _fixed_by_fs_commit helper Johannes Thumshirn
2026-02-13  7:13   ` Christoph Hellwig [this message]
2026-02-13  7:01 ` [PATCH 2/2] fstests: use _fixed_by_fs_commit where appropriate Johannes Thumshirn
2026-02-13  7:13   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aY7PCGwxpwxx90yW@infradead.org \
    --to=hch@infradead.org \
    --cc=johannes.thumshirn@wdc.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-xfs@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.