From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 891B7EDF150 for ; Fri, 13 Feb 2026 11:09:35 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1vqr2e-0004w1-RV; Fri, 13 Feb 2026 06:08:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqr2T-0004Rx-Am for qemu-devel@nongnu.org; Fri, 13 Feb 2026 06:08:45 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1vqr2Q-0006Cz-T2 for qemu-devel@nongnu.org; Fri, 13 Feb 2026 06:08:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1770980920; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references; bh=3I8F334q7ubrbQX115loeOfDWSrAuQ248+py3NkA89I=; b=NyNIO4rzROKUwhiFB/imyapFWZfNYcO9AOvP5jXjIgDEPfmkZdEbuNbyAUVgtrRWPE4+bQ ZzTk1f3oZdBHcaS10TxYCWH1GFnh1X3n8OUVdo03KWLaQEHlPmlh81XGcqI1gxoTqJ9v1Z Jas6QO0mmRiQ1jDShLM0bFfczt7qXdA= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-161-rUbn4aEgM4-BnxysE50_rw-1; Fri, 13 Feb 2026 06:08:36 -0500 X-MC-Unique: rUbn4aEgM4-BnxysE50_rw-1 X-Mimecast-MFC-AGG-ID: rUbn4aEgM4-BnxysE50_rw_1770980916 Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D46F61955D88; Fri, 13 Feb 2026 11:08:35 +0000 (UTC) Received: from redhat.com (unknown [10.45.225.43]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6D9BB3000225; Fri, 13 Feb 2026 11:08:34 +0000 (UTC) Date: Fri, 13 Feb 2026 11:08:30 +0000 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Paolo Bonzini Cc: qemu-devel@nongnu.org, Aidan Khoury Subject: Re: [PULL v2 29/41] i386/cpu: Fix incorrect initializer in Diamond Rapids definition Message-ID: References: <20260213102109.107491-1-pbonzini@redhat.com> <20260213102109.107491-2-pbonzini@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20260213102109.107491-2-pbonzini@redhat.com> User-Agent: Mutt/2.2.14 (2025-02-20) X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: qemu development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Feb 13, 2026 at 11:21:09AM +0100, Paolo Bonzini wrote: > From: Aidan Khoury > > The new Diamond Rapids x86 cpu model definition that was added in 7a6dd8bde1 > has an unexpected comma in the `.features[FEAT_VMX_EXIT_CTLS]` subobject > initializer, causing the prior initialization to be overridden. For this > reason `VMX_VM_EXIT_SAVE_DEBUG_CONTROLS | VMX_VM_EXIT_HOST_ADDR_SPACE_SIZE` > is not included. > > Fix this by replacing the comma with the missing bitwise OR to properly > combine all the flags into a single bitmask value. > > Fixes: 7a6dd8bde159 ("i386/cpu: Add CPU model for Diamond Rapids") > Signed-off-by: Aidan Khoury That's missing your S-o-B > --- > target/i386/cpu.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/target/i386/cpu.c b/target/i386/cpu.c > index 201c5d5c210..eaa01438c1b 100644 > --- a/target/i386/cpu.c > +++ b/target/i386/cpu.c > @@ -5579,7 +5579,7 @@ static const X86CPUDefinition builtin_x86_defs[] = { > MSR_VMX_EPT_INVVPID_ALL_CONTEXT | > MSR_VMX_EPT_INVVPID_SINGLE_CONTEXT_NOGLOBALS, > .features[FEAT_VMX_EXIT_CTLS] = > - VMX_VM_EXIT_SAVE_DEBUG_CONTROLS | VMX_VM_EXIT_HOST_ADDR_SPACE_SIZE, > + VMX_VM_EXIT_SAVE_DEBUG_CONTROLS | VMX_VM_EXIT_HOST_ADDR_SPACE_SIZE | > VMX_VM_EXIT_LOAD_IA32_PERF_GLOBAL_CTRL | > VMX_VM_EXIT_ACK_INTR_ON_EXIT | VMX_VM_EXIT_SAVE_IA32_PAT | > VMX_VM_EXIT_LOAD_IA32_PAT | VMX_VM_EXIT_SAVE_IA32_EFER | > -- > 2.52.0 > > With regards, Daniel -- |: https://berrange.com ~~ https://hachyderm.io/@berrange :| |: https://libvirt.org ~~ https://entangle-photo.org :| |: https://pixelfed.art/berrange ~~ https://fstop138.berrange.com :|