From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CO1PR03CU002.outbound.protection.outlook.com (mail-westus2azon11010000.outbound.protection.outlook.com [52.101.46.0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4319C26F293 for ; Fri, 13 Feb 2026 18:21:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.46.0 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771006910; cv=fail; b=SMMdY5kWmT1Y9XS9y6/dYxQfOdh9fP2zPuemIaZC1++u6VkCtFcw2EzuIt64Ei89ibAsZ70TYDBLNoWsMfqAUuh59mAuzqlVdgP3t7Bfib3hIpMgKlzrYFmp9+spleUB65PskF+drFj9o5PRyL8NiBZ3foG5b8qrki0p+ClDU+g= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771006910; c=relaxed/simple; bh=yKbF+HelHeLAQvIumJrjK+xjIloQ4jJ8+4OGm85nHAU=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=oz+D8DVwov4Evnra6M4G9UPcf2VIy6IxsBfusajrdMD9wbbcF5vwKY0yUfRU85CsW0FKtnEMArE1TplJ3QsJMTNGWyIUgwzEC356SFunVyQ1KuYngUbvYq3pBq4lRQJVPEnys0sPlPiNKiBqICNy9bECo0H1yxStqOOKcsBlCfA= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=r+JSVNXJ; arc=fail smtp.client-ip=52.101.46.0 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="r+JSVNXJ" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=wRr2FhZTGo9+tPFGR4SJZ0+2D5xEOzCSrEBbTjjTT8Sm+d4PDD0ffSaHZ07A/8UinKyqqL/Z0tGK1xDnUOshZ9amxN8QZ2tefm1dqrzujYnszlxdlX75xUlex7al9WjLYFpTNzg/xuZnEz+FFtgsuupcSlZMTrbF7ajUQU8z6+qtvaG7dlfqP/U3jz2aL8/1p21ZyXWEZXOH/CjCExMacr+zBjRKRhwQexULBSZ4MaOzCNRGc1hBdRdcwqCrbsE/IdEACYWP8OCk2wWzkliCNS1z/M3jt3ekXsvVUU2A9RWa4MBfVV1f+ST7jswegbGIKOwgwpFZ/yrNpY1ujO8ERw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c90vQGVS96cWRbFj+Q1hydNB/CzQ1+WNzUbkCVOMFLQ=; b=fBX5r93vGIXhM+mjp0FW7coB5m0vZaEASS+8WepHS4D/uSKnZ2ZQgkv4kcbwqvZqyIvDPauqCMzMhxOxfhDhTajhboTI3rvXGHWoSKzWs55ZP64bImhF4wtMOeslysZ4+lN1IO63aMm6pLmKzwDGJJCSc2QfqfI6vBqc4MJ27iBQI/vRJWYPR5B4Dc0UdUXlIQSjVoT0pQrUj6/CG2ogXJI29tUe7k6jaTsOmXV9NLuWgp4pxDZItU2BHMZIqLHkw3pr/EX+tqcJlXVdcfro5r3VLgLk61KxvjgG74FjB0HUaYVbOb2RhIexwMOpNkiZ3wf2V0r2qxYt8kmATDM6hA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=c90vQGVS96cWRbFj+Q1hydNB/CzQ1+WNzUbkCVOMFLQ=; b=r+JSVNXJowyAp/C0wWTtUzBF5YKfMtBLRbjtH6K/IqRo00MqxL+fca3UTRx1ukylShANAdPShNSK730UBK34QVdrtci7HHacMaPo1mkLc0SQKB0DtSKK+px9gN9s9YB9OESs0bwbesvHCHrxXHBsFqWxNuH8WJPJGOajxb50JEn4uwpHca1p5tmpb6oZXWW/kEw6UzwfiVimp2mbr3eNgVZeDqwMqzXYSC3gYjzoAGXksnwVpoh6/YB8kXIbvxUturknWmGKdcgsnnkeSVDzpe9bZ1oRYg8QStVvix6wbaFeqqtt5oRDCfHZYz66n6wNDJ2bkh60V5t0rPUhydpqlg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from DS0PR12MB8786.namprd12.prod.outlook.com (2603:10b6:8:149::17) by IA1PR12MB7637.namprd12.prod.outlook.com (2603:10b6:208:427::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9611.13; Fri, 13 Feb 2026 18:21:46 +0000 Received: from DS0PR12MB8786.namprd12.prod.outlook.com ([fe80::cd1a:bacf:6ab9:6f91]) by DS0PR12MB8786.namprd12.prod.outlook.com ([fe80::cd1a:bacf:6ab9:6f91%3]) with mapi id 15.20.9611.008; Fri, 13 Feb 2026 18:21:45 +0000 Date: Fri, 13 Feb 2026 13:12:41 -0500 From: Yury Norov To: Arnd Bergmann Cc: Matt Wu , Arnd Bergmann , Yury Norov , linux-kernel@vger.kernel.org Subject: Re: [PATCH] objpool: fix minimum alignment of 'struct objpool_slot' Message-ID: References: <20260210103530.3028454-1-arnd@kernel.org> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260210103530.3028454-1-arnd@kernel.org> X-ClientProxiedBy: BN9P221CA0002.NAMP221.PROD.OUTLOOK.COM (2603:10b6:408:10a::9) To DS0PR12MB8786.namprd12.prod.outlook.com (2603:10b6:8:149::17) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS0PR12MB8786:EE_|IA1PR12MB7637:EE_ X-MS-Office365-Filtering-Correlation-Id: 7d3fae81-49b1-410e-bb0a-08de6b2cbeb5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?R9Bs5kYwxtpnV4z6CV+6USmaImWbQEu9dMRDkCnUHx9eAUJOTZqBQzo1fyIW?= =?us-ascii?Q?dlq/yT68PgLJOViCeGzIsaw4pZlusXU9MHsaeAMAuWq5Um0HXy30UgOwrntk?= =?us-ascii?Q?qWy12HbL2f6cU5nRaiea2EC6tjqlMI294gcZ40/8huRaZb1IoPDmp3a6+FXJ?= =?us-ascii?Q?H9PavbnJcVhGyY45bkNGgy+TAiBk2vFnXv42OgriedFMjU7sSW4YDkNI0KFm?= =?us-ascii?Q?qXCrq0bVScRvlpkgdkybZcmZtV90VIgf6Q5Xm3RKO7BhpmX7brmopWpnluTA?= =?us-ascii?Q?yYbwWdIE2VYD2FuRxjIOTIVYoZCrNsVimV93uacMd1dNoAnUR7Imw22xe+bF?= =?us-ascii?Q?4ynmcj7v24OOtM+x4ZEydupBr0vD2DBVt9myqeV6gqWdGgcqrFz101dz73dt?= =?us-ascii?Q?PlpLLCvmAhhI/AuiZEYFhu9OYvyl0A+a795JQEWlq0O8z/1SuJ/m6a3Haxgz?= =?us-ascii?Q?Tx8mViPavnZ+PN8b1urvLrGbCR9g6O29tc8T0nAjgRYXkkCP9bE/SRuLJZUw?= =?us-ascii?Q?Zm3+xRzpmqOLqujx7av87wZL8zW1i7NdZ4LzGCI0rEgVHp/YgBzgGQDEKZZr?= =?us-ascii?Q?g3pKabgUif3qNqJHAsI63cNDiRGj3qSJjtOUToN639o1+nDA1GmNyUGDKsXO?= =?us-ascii?Q?R2zA4hVnspMyaiJ1tI4MC/S3QkXMKcbCPS2y6H0AbBm1LHfVYBMHU6NS65YZ?= =?us-ascii?Q?a26xTcgMChAbiy7/RCAyyOgwzOg68EFOVTDmAngYZuNjivxecuJcRN7NNOdh?= =?us-ascii?Q?zR2oUWoEV+8LAHbNDTQquDDani3JQEkn53pm3DpxYwlPtNBM3S1YQ02tKv9p?= =?us-ascii?Q?/iBjJLBA4cdMI3OC0s5a6WdchP8N4sZKBKC7D4/oh4utryT5VPcLxM7T15tQ?= =?us-ascii?Q?6yFC19XbnsupnGbxqmLcfzb5ggix2PKcaRrXLpANck4oc8kA8fsq+6nLNDSX?= =?us-ascii?Q?y6B/tvbKwZJXWYfledE0rpe+UbfJh3rszn1G52KrLmvx5+F9MRKSYMLHICKN?= =?us-ascii?Q?f9LMJ6vxKL7V1m1OW9EuFerX0ZhkRxDwa93WpOjyYTq0o8teWq/OT1Ybwe6G?= =?us-ascii?Q?/RReZEmXotekU0XVh3CX2IlG2d6qxjXtNwKjFY36aIddXp2S5cZvzfQ7Av/Q?= =?us-ascii?Q?rggXbqsr1rbldayC4SV+eZgznexwXgeQIalYvmfWh0Ei2ZV7CatGKac+K57o?= =?us-ascii?Q?rgtiCN/NpD5kEtsDzVu68PyklXVO+mQy75ZrDqEytu6LMZpi9/J1qyxssT5g?= =?us-ascii?Q?LowehFVM1xPgNdRHlmQPqrBpLpQjzDRDEAYVbYILh1Pep6UWLk00l/WJXcmF?= =?us-ascii?Q?tk7LvOoudRVWRdWzml6wOl+uD2hsreHC4FEN0SMN9mjaHl0PJuLzr35tG/f6?= =?us-ascii?Q?zvDjx1J7ID+hMcR0BPSrkjVVeGvA8XfM++R4+ym5r5CyoA6zxUj8TZ35XVpd?= =?us-ascii?Q?WqD6tYN1vMXkguF1qEElhD5z047/rN9Yb243DKNVjLw/rTNQe0fLGzhu6634?= =?us-ascii?Q?4tARN3vfh8nKo9e/e07Zt9hj3odgbRzPnEkVCgLbXzlpNwvMs8J73ih1IVlN?= =?us-ascii?Q?+BHECYwOydaqYozcd9I=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DS0PR12MB8786.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Q6PF61ibO4/LAwqWQC6ysRQ+GgZvXzLIfbKThCseQTohRwyyoxWcFOU9YkHV?= =?us-ascii?Q?Y0tT4M2V3NKTeyUIeq22wdPKqt4qnAo73aNZbpCn7reAsWJnGI+xi4ha5T7l?= =?us-ascii?Q?hnP3joCndDxbQy0oa3AbMFhe1iYicRnfzBkBTpFd9kxzhh2OoB21qzMMSXyi?= =?us-ascii?Q?wTSVgRhVkDYl7Zzau0gg68EyhNPTBiGpQ7rwBx0XCcJMZoONkWxwn7MzAttW?= =?us-ascii?Q?YcvtIllZsSzIJj/d6I1HMYbAFSvdLKr+W7orzhbzNUxAl2hZvfgJXZDvbtqs?= =?us-ascii?Q?6xC5qHU6dEnIa2lGRKS4ZADz90nszzyk6M2rR6efTi+BI2SCulzWfzfmd52d?= =?us-ascii?Q?vuDpilce/rEpiFXG7pJkVpeJe4n/CPzg5lPhoX9b2UJUHSjC5dLfLc74uJuE?= =?us-ascii?Q?tz2Nv6KJnrhCLDn5rqeC3O5SrhyKpSQ3ycYr5WledWEqcHGv/3tMZrZEjddX?= =?us-ascii?Q?iE0x9T3OshJnk62I67prDM426eQXDHZ1egUtuRC6RqFL/6QXizF8OBk3egWy?= =?us-ascii?Q?unjMFsq74R6LYemdowTLey93G2GMY0ZguPDmlNTvKOoc3VkqBN1HBVefp2aj?= =?us-ascii?Q?gI/vxZIB3a+1QLZQBGXO99ou3wQ8wH2zqX+8lmXToiGL5l4+uLYsLW1/v2nx?= =?us-ascii?Q?D8T/C9gL/l4UzOBhR4Ok70Pj9Z8PZ7ilvqtURbZtR2Jve6o7Mp5NwbcUpieG?= =?us-ascii?Q?vdfjAVW3cWOrf2VvXqGcQmGtghiH/03Wk0wIpcOvN+MBftr8ShpQ/O2Nmzru?= =?us-ascii?Q?lodSP5x8XFk841IjzwDUpkK2ewuBf1FtOiW+cASCgq1NTzLTYY/r7YYKNgH2?= =?us-ascii?Q?t8SO+fMFKU67wICESnwuFdkx9cqYbLtr+2ixKh/qY87EeRjv5YTCGspDAFmz?= =?us-ascii?Q?zb9uLBXbCWz+QUYjNvZNd60bisFr4t9kCz3KkP1Z35Jr+xX3AJs0pyEykxZU?= =?us-ascii?Q?gqj8Nu+ZufbSd8LZ7rF8x6V2m1Vbyo53ohF8rEjAzKrFzof9Oj+lLtnEbYIX?= =?us-ascii?Q?D1ZGO+NuVcihPF3sZOtGJjotalXP0dF7qKGNPjGqjAB6PVn8YSKwvIov4ZqO?= =?us-ascii?Q?kFepwvaHP0gUBQreYLQ07G368PIKX3B+rbWJstbALG/8aaP7B3Q14KXMv0RR?= =?us-ascii?Q?HDPs7SjLSuKnqW03EakGduiPnDGPT2JVzJLVLDL1lgVds2U30QCYc1+w5KS4?= =?us-ascii?Q?4ObdyEsK2B1mcLt9WYv5lT75rA5xjjzuSIuABWK0s42g64AoaaG+u3TrdE9r?= =?us-ascii?Q?mq+DhC9b5EnmFx60Ou7+oNOJZMAfHADdBVLgPsQHcZJI3SRUuDlg6TeNJIAw?= =?us-ascii?Q?yfzBPFIf/dMM1snTv+bMSn2y77/BZCyG7KXYKYqzJzQGr3rkUvqVnE+Ro2Cg?= =?us-ascii?Q?+NMJyshob+96ZjolzrMwLteYBcnM6Hme7tONT2Dhlc+E4wvsB43/1adhtW18?= =?us-ascii?Q?0mz+MY8nrCsiXe0cJkHzOm6asBba37ArmzpoRW2ffA9SgEoyts9G7Ut0KgYd?= =?us-ascii?Q?bEVgV9rtXsmUN532JyKI7Z0o04Aq1PzBDgJF0JllT4mgqtiQAAegNYY7ijt3?= =?us-ascii?Q?7lJpEq63XSEVdk2fKxZ7YfpKNulMfmXod9OnPX9Ur3GFNNXTPzDBeq1+f97T?= =?us-ascii?Q?Wf7l4sEMTktj5E0oVHCT/zlSuIcSO0gWLm/elNl2E4UEMpsGy9++aDS6B4GU?= =?us-ascii?Q?IfVWx8AkUVmjCzbr3YITltcSeP0PoVUPstw3aGhY4zkPsO5/C/N/cg1aBhfk?= =?us-ascii?Q?5JIGnoXzJQ=3D=3D?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d3fae81-49b1-410e-bb0a-08de6b2cbeb5 X-MS-Exchange-CrossTenant-AuthSource: DS0PR12MB8786.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2026 18:21:45.7961 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 5jlLOq5JlMe65Q0ucDQBPry+htyYEDJwlqZDg4+dJTFSXChtS48Qg1rq0hnGXqOrt2KwiwfsZVZLnkaFcju9PQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7637 Hi Arnd, Would you like me to route this with my branch? Please let me know if anything needed on my side. Thanks, Yury On Tue, Feb 10, 2026 at 11:35:24AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > Members of objpool_slot get passed into try_cmpxchg_release(), > which does not work on most architectures unless they are > naturally aligned. Marking the structure as packed makes it > only byte-aligned, as shown by this (normally disabled) warning: > > include/linux/objpool.h:156:56: warning: taking address of packed member of 'struct objpool_slot' may result in an unaligned pointer value [-Waddress-of-packed-member] > 156 | if (try_cmpxchg_release(&slot->head, &head, head + 1)) > | ~^~~~~~~~~~~~ > > As the struct members are all tightly packed on all architectures, > Just remove the '__packed annotation to give it the required > alignment of the native word size. > > Signed-off-by: Arnd Bergmann > --- > include/linux/objpool.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/objpool.h b/include/linux/objpool.h > index b713a1fe7521..f678b35b20b1 100644 > --- a/include/linux/objpool.h > +++ b/include/linux/objpool.h > @@ -56,7 +56,7 @@ struct objpool_slot { > uint32_t last; > uint32_t mask; > void *entries[]; > -} __packed; > +}; > > struct objpool_head; > > -- > 2.39.5