From: Peng Fan <peng.fan@oss.nxp.com>
To: ziniu.wang_1@nxp.com
Cc: shawnguo@kernel.org, s.hauer@pengutronix.de, frank.li@nxp.com,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
kernel@pengutronix.de, festevam@gmail.com,
devicetree@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/3] arm64: dts: imx93-9x9-qsb: change usdhc tuning step for eMMC and SD
Date: Mon, 2 Feb 2026 11:40:11 +0800 [thread overview]
Message-ID: <aYAcm+y5wkXtXq5/@shlinux89> (raw)
In-Reply-To: <20260129080439.2910727-1-ziniu.wang_1@nxp.com>
On Thu, Jan 29, 2026 at 04:04:37PM +0800, ziniu.wang_1@nxp.com wrote:
>From: Luke Wang <ziniu.wang_1@nxp.com>
>
>During system resume, the following errors occurred:
>
> [ 430.638625] mmc1: error -84 writing Cache Enable bit
> [ 430.643618] mmc1: error -84 doing runtime resume
>
>For eMMC and SD, there are two tuning pass windows and the gap between
>those two windows may only have one cell. If tuning step > 1, the gap may
>just be skipped and host assumes those two windows as a continuous
>windows. This will cause a wrong delay cell near the gap to be selected.
>
>Set the tuning step to 1 to avoid selecting the wrong delay cell.
>
>For SDIO, the gap is sufficiently large, so the default tuning step does
>not cause this issue.
Adding a fix tag? one more question, I see all three patches are all
changing to 1, could this change be in imx91_93_common.dtsi?
Regards
Peng
>
>Signed-off-by: Luke Wang <ziniu.wang_1@nxp.com>
>---
> arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts b/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts
>index 0852067eab2c..197c8f8b7f66 100644
>--- a/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts
>+++ b/arch/arm64/boot/dts/freescale/imx93-9x9-qsb.dts
>@@ -507,6 +507,7 @@ &usdhc1 {
> pinctrl-2 = <&pinctrl_usdhc1_200mhz>;
> bus-width = <8>;
> non-removable;
>+ fsl,tuning-step = <1>;
> status = "okay";
> };
>
>@@ -519,6 +520,7 @@ &usdhc2 {
> vmmc-supply = <®_usdhc2_vmmc>;
> bus-width = <4>;
> no-mmc;
>+ fsl,tuning-step = <1>;
> status = "okay";
> };
>
>--
>2.34.1
>
next prev parent reply other threads:[~2026-02-02 3:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 8:04 [PATCH v2 1/3] arm64: dts: imx93-9x9-qsb: change usdhc tuning step for eMMC and SD ziniu.wang_1
2026-01-29 8:04 ` [PATCH v2 2/3] arm64: dts: imx93-11x11-evk: " ziniu.wang_1
2026-01-29 8:04 ` [PATCH v2 3/3] arm64: dts: imx91-11x11-evk: " ziniu.wang_1
2026-01-29 17:41 ` [PATCH v2 1/3] arm64: dts: imx93-9x9-qsb: " Frank Li
2026-02-02 3:40 ` Peng Fan [this message]
2026-02-03 3:19 ` Luke Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYAcm+y5wkXtXq5/@shlinux89 \
--to=peng.fan@oss.nxp.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=ziniu.wang_1@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.