Re: [PATCH 2/4] drm/i915/vrr: Avoid vrr for PCON with HDMI2.1 sink

["Ville Syrjälä" <ville.syrjala@linux.intel.com>]

On Tue, Nov 11, 2025 at 03:00:05PM +0530, Ankit Nautiyal wrote:
> Currently we do not support VRR with HDMI so skip vrr compute
> config step for DP PCON with HDMI sink.
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_vrr.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
> index 00cbc126fb36..7a58e1f8acea 100644
> --- a/drivers/gpu/drm/i915/display/intel_vrr.c
> +++ b/drivers/gpu/drm/i915/display/intel_vrr.c
> @@ -42,7 +42,14 @@ bool intel_vrr_is_capable(struct intel_connector *connector)
>  	case DRM_MODE_CONNECTOR_DisplayPort:
>  		if (connector->mst.dp)
>  			return false;
> +
>  		intel_dp = intel_attached_dp(connector);
> +		/*
> +		 * VRR via PCON is currently unsupported.
> +		 * TODO: Add support for VRR for DP HDMI2.1 PCON.
> +		 */
> +		if (intel_dp_has_hdmi_sink(intel_dp))

That just checks what the EDID says about HDMI support, it
doesn't really mean anything wrt. PCON vs. not.

So if we eg. have a DVI sink attach through a PCON we won't
bail out here.

> +			return false;
>  
>  		if (!drm_dp_sink_can_do_video_without_timing_msa(intel_dp->dpcd))
>  			return false;
> -- 
> 2.45.2

-- 
Ville Syrjälä
Intel