Re: [Buildroot] [PATCH 1/1] package/mpir: fix build errors

[Thomas Petazzoni via buildroot <buildroot@buildroot.org>]

Hello,

On Sun, Oct 26, 2025 at 10:02:21AM +0100, Bernd Kuhls wrote:
> Added upstream patch to fix configure with gcc-14.

This should have been one commit.

> Updated project URL and _SITE due to previous site not being available
> anymore: https://github.com/wbhart/mpir/pull/298

And this should have been another commit, as it's unrelated.

So I've split into two commits.

> The github helper could not be used, for details see
> https://patchwork.ozlabs.org/project/buildroot/patch/20250203-repair_mpir-v1-1-db848d68b586@bootlin.com/
> In contrast this commit does not bump the package version.

This is not what the comment was saying, and in fact using the github
helper works just fine, so I've used that. The trick is that the old
tarball was .tar.bz2 while the new one from github is .tar.gz, so
there is no conflict.

> +# mpir tries to build/install .info doc even if makeinfo isn't installed
> +# on the host, so we have to disable global doc installation to prevent
> +# autobuild errors.
> +define MPIR_DISABLE_DOC_INSTALL
> +	$(SED) 's/SUBDIRS += mpn fft mpz mpq mpf printf scanf cxx tune doc/SUBDIRS += mpn fft mpz mpq mpf printf scanf cxx tune/' \
> +		$(@D)/Makefile.am
> +endef
> +MPIR_POST_PATCH_HOOKS += MPIR_DISABLE_DOC_INSTALL

This was quite complicated, so I simplified to:

+# We don't care about the documentation
+MPIR_CONF_ENV = MAKEINFO=true

which is the approach we use in a number of packages already when
makeinfo gets annoying.

So, applied your change after splitting into two commits, and doing
various improvements along the way.

Thanks!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot