All of lore.kernel.org
 help / color / mirror / Atom feed
From: Peng Fan <peng.fan@oss.nxp.com>
To: Frank Li <Frank.Li@nxp.com>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 08/10] ARM: dts: imx7ulp: remove #clock-cells from clock-controller@40410000
Date: Tue, 3 Feb 2026 09:52:39 +0800	[thread overview]
Message-ID: <aYFU5w1LpxoUiQH/@shlinux89> (raw)
In-Reply-To: <20260202-imx31_dts_warning-v1-8-434dd2643c3b@nxp.com>

On Mon, Feb 02, 2026 at 02:43:25PM -0500, Frank Li wrote:
>According to the fsl,imx7ulp-pm.yaml binding, clock-controller@40410000 is
>not a clock provider. Remove the #clock-cells property to fix the following
>CHECK_DTBS warning:
>  clock-controller@40410000 (fsl,imx7ulp-smc1): '#clock-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
>
>Signed-off-by: Frank Li <Frank.Li@nxp.com>
>---
> arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
>index 880b9a4f32b0846a773dbf9ad30715c84ac2fda6..6d8853d36d930aabb98fb57f49d6153ca6597561 100644
>--- a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
>+++ b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
>@@ -291,7 +291,6 @@ pcc2: clock-controller@403f0000 {
> 		smc1: clock-controller@40410000 {
> 			compatible = "fsl,imx7ulp-smc1";
> 			reg = <0x40410000 0x1000>;
>-			#clock-cells = <1>;

Need to fix binding, this is a clock controller and needs #clock-cells to work
properly.

There is a driver for this compatible:
drivers/clk/imx/clk-imx7ulp.c

Regards,
Peng

> 			clocks = <&scg1 IMX7ULP_CLK_CORE_DIV>,
> 				 <&scg1 IMX7ULP_CLK_HSRUN_CORE_DIV>;
> 			clock-names = "divcore", "hsrun_divcore";
>
>-- 
>2.34.1
>

  reply	other threads:[~2026-02-03  1:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02 19:43 [PATCH 00/10] ARM: dts: cleanup some CHECK_DTB warings Frank Li
2026-02-02 19:43 ` [PATCH 01/10] ARM: dts: imx35: rename emi to emi-bus to fix CHECK_DTBS warning Frank Li
2026-02-02 19:43 ` [PATCH 02/10] ARM: dts: imx35: rename i2c clock-names to ipg Frank Li
2026-02-02 19:43 ` [PATCH 03/10] ARM: dts: imx35: remove simple-bus 'usbphy' Frank Li
2026-02-02 19:43 ` [PATCH 04/10] ARM: dts: imx51-ts4800: rename fpga@0 to fpga@0,0 Frank Li
2026-02-02 19:43 ` [PATCH 05/10] ARM: dts: imx51-babbage: rename at45db321d@1 to flash@1 Frank Li
2026-02-03 13:59   ` Daniel Baluta
2026-02-02 19:43 ` [PATCH 06/10] ARM: dts: imx53: drop fallback compatible "dlg,da9052" Frank Li
2026-02-02 19:43 ` [PATCH 07/10] ARM: dts: imx6qdl-sr-som-ti: use fixed-clock instead of clock-frequency Frank Li
2026-02-02 19:43 ` [PATCH 08/10] ARM: dts: imx7ulp: remove #clock-cells from clock-controller@40410000 Frank Li
2026-02-03  1:52   ` Peng Fan [this message]
2026-02-03 15:37     ` Frank Li
2026-02-02 19:43 ` [PATCH 09/10] ARM: dts: imx53-smd: Add power supply node for fsl,sgtl5000 Frank Li
2026-02-02 19:43 ` [PATCH 10/10] ARM: dts: imx7s-warp: Remove data-lanes and clock-lanes for ov2680 Frank Li
2026-02-24 19:57 ` (subset) [PATCH 00/10] ARM: dts: cleanup some CHECK_DTB warings Frank Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYFU5w1LpxoUiQH/@shlinux89 \
    --to=peng.fan@oss.nxp.com \
    --cc=Frank.Li@nxp.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.