From: Mike Rapoport <rppt@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mm-commits@vger.kernel.org, vishal.moola@gmail.com,
songshuaishuai@tinylab.org, samuel.holland@sifive.com,
rdunlap@infradead.org, pawan.kumar.gupta@linux.intel.com,
palmer@dabbelt.com, mingo@kernel.org, lirongqing@baidu.com,
leitao@debian.org, kevin.brodsky@arm.com, kees@kernel.org,
fvdl@google.com, elver@google.com, cuiyunhui@bytedance.com,
corbet@lwn.net, bp@alien8.de, bjorn@rivosinc.com,
bhelgaas@google.com, arnd@arndb.de, aou@eecs.berkeley.edu,
alex@ghiti.fr, ruanjinjie@huawei.com
Subject: Re: [merged mm-nonmm-stable] riscv-kexec-add-support-for-crashkernel-cma-reservation.patch removed from -mm tree
Date: Tue, 3 Feb 2026 09:43:52 +0200 [thread overview]
Message-ID: <aYGnODFtgjyiRLB9@kernel.org> (raw)
In-Reply-To: <20260202125404.343361f6696777efc3acaab1@linux-foundation.org>
On Mon, Feb 02, 2026 at 12:54:04PM -0800, Andrew Morton wrote:
> On Sun, 1 Feb 2026 15:29:17 +0100 Mike Rapoport <rppt@kernel.org> wrote:
>
> > > From: Jinjie Ruan <ruanjinjie@huawei.com>
> > > Subject: riscv: kexec: add support for crashkernel CMA reservation
> > > Date: Mon, 26 Jan 2026 16:07:38 +0800
> >
> > I commented on almost identical patch for arm64
> >
> > https://lore.kernel.org/all/20260126081334.699147-1-ruanjinjie@huawei.com/
> >
> > about moving the exclusion of CMA regions into the core crash code.
> > The same comment applies to this one as well. Sorry I didn't mention that
> > more explicitly.
>
> Thanks.
>
> So IIUC this patch is OK, but we should reduce the code duplication in
> this area?
The patch is Ok in the sense it does not break anything :)
I'd like to see series with PATCH 1/3 moving the duplicated code from x86
and powerpc to the crash_core.c and patches 2 and 3 adding arm64 and riscv
support for CMA.
Requiring refactoring upfront rather than fixing this afterwards makes
maintainers life easier ;-)
--
Sincerely yours,
Mike.
next prev parent reply other threads:[~2026-02-03 7:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-01 0:17 [merged mm-nonmm-stable] riscv-kexec-add-support-for-crashkernel-cma-reservation.patch removed from -mm tree Andrew Morton
2026-02-01 14:29 ` Mike Rapoport
2026-02-02 20:54 ` Andrew Morton
2026-02-03 7:43 ` Mike Rapoport [this message]
2026-02-03 16:27 ` Andrew Morton
2026-02-03 17:45 ` Sourabh Jain
2026-02-04 2:42 ` Jinjie Ruan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYGnODFtgjyiRLB9@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alex@ghiti.fr \
--cc=aou@eecs.berkeley.edu \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=bjorn@rivosinc.com \
--cc=bp@alien8.de \
--cc=corbet@lwn.net \
--cc=cuiyunhui@bytedance.com \
--cc=elver@google.com \
--cc=fvdl@google.com \
--cc=kees@kernel.org \
--cc=kevin.brodsky@arm.com \
--cc=leitao@debian.org \
--cc=lirongqing@baidu.com \
--cc=mingo@kernel.org \
--cc=mm-commits@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=rdunlap@infradead.org \
--cc=ruanjinjie@huawei.com \
--cc=samuel.holland@sifive.com \
--cc=songshuaishuai@tinylab.org \
--cc=vishal.moola@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.