All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dominique Martinet <asmadeus@codewreck.org>
To: Qu Wenruo <wqu@suse.com>
Cc: Qu Wenruo <quwenruo.btrfs@gmx.com>,
	Christoph Anton Mitterer <calestyo@scientia.org>,
	linux-btrfs <linux-btrfs@vger.kernel.org>
Subject: Re: We have a space info key for a block group that doesn't exist
Date: Tue, 3 Feb 2026 17:17:35 +0900	[thread overview]
Message-ID: <aYGvH2L6StMrLBOB@codewreck.org> (raw)
In-Reply-To: <fa4a4321-7b45-45e1-b372-9ada2ffbc8ef@suse.com>

Qu Wenruo wrote on Tue, Feb 03, 2026 at 06:17:14PM +1030:
> > We're running rountine btrfsck before copying the filesystem for cloning
> > in one of our tools, and I'm starting to get user reports of errors due
> > to this error (we run an ancient 5.10 kernel but there hadn't been any
> > such report, and now we just got two in a couple of weeks so something
> > must have been backported to the stable tree...)
> > 
> > Anyway, I agree with your answer that it's safe to ignore, but it's not
> > obvious for users to decide that, so I'd like to address this somehow.
> > 
> > If it's really harmless, could it be printed as info message but not
> > change the btrfsck return code? (e.g. if that's the only error, return
> > success)
> 
> I think it's possible to change it to a warning, not an error, but we are
> going to have proper automatic kernel in v6.20 kernel.
> 
> With that said, at least for us developers a proper error will help us more,
> and prevent further similar problems.
> 
> Trading between end users complains and future proof, I still prefer to keep
> it as an error for now.

Fair enough, I understand.

> > If you think it's worth keeping as an error, would you (or someone else)
> > happen to have any idea where I should start looking?
> 
> In v6.20 kernel, the first RW mount of the fs will automatically fix the
> problem.
> 
> The patch is here:
> 
> https://lore.kernel.org/linux-btrfs/f58857f1ac741bd1fb4fa2e7ec56ed87815bb1f5.1766198159.git.wqu@suse.com/

Oh!
I only searched for the btrfsck error message so this didn't come up,
sorry.
That's great, thank you.


> And it's already in our for-next branch, heading towards v6.20 kernel.
> 
> I will backport that fix to older LTS kernels (6.6 and 6.12 planned) so that
> even older kernel users will get their fs fixed properly.

Thanks.. Unfortunately that part of the code changed greatly in 5.11
(btrfs_start_pre_rw_mount didn't even exist back in 5.10), so I'll just
give up on that one -- I just don't think it's worth the effort for our
old kernel.

However your commit message explains why we didn't see it before (it's
limited to a range of "bad" btrfs-progs version), and we've already
upgraded to btrfs-progs-6.17 so hopefully will stop seeing it as soon as
people move away from the "bad" 6.14 version that likely caused the
problem (I'll check a bit more on this)

Thank you,
-- 
Dominique Martinet | Asmadeus

  reply	other threads:[~2026-02-03  8:17 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17  2:08 We have a space info key for a block group that doesn't exist Christoph Anton Mitterer
2025-11-17  2:18 ` Qu Wenruo
2025-11-18 23:27   ` Christoph Anton Mitterer
2025-11-18 23:29     ` Qu Wenruo
2026-02-03  7:06       ` Dominique Martinet
2026-02-03  7:47         ` Qu Wenruo
2026-02-03  8:17           ` Dominique Martinet [this message]
2026-02-05  1:44       ` Christoph Anton Mitterer
2026-02-05  4:24         ` Qu Wenruo
2026-02-05  4:30           ` Christoph Anton Mitterer
2026-02-05  4:43             ` Qu Wenruo
2026-02-05  4:50               ` Christoph Anton Mitterer
2026-02-05  4:53                 ` Qu Wenruo
2026-02-05 14:48                   ` Christoph Anton Mitterer
2026-02-05 20:48                     ` Qu Wenruo
2026-02-05 23:56                       ` Christoph Anton Mitterer
2026-02-06  3:45                         ` Qu Wenruo
2026-02-07  1:19                           ` Christoph Anton Mitterer
2026-02-07  1:27                             ` Christoph Anton Mitterer
2026-02-07  2:34                               ` Qu Wenruo
2026-02-07  5:00                                 ` Christoph Anton Mitterer
2026-02-07 16:47                                   ` space_info METADATA (sub-group id 0) has 691535872 free, is not full // open_ctree failed: -2 Christoph Anton Mitterer
2026-02-09  3:21                                     ` Qu Wenruo
2026-02-09  3:32                                       ` Christoph Anton Mitterer
2026-02-09  3:48                                         ` Qu Wenruo
2026-02-09  3:58                                           ` Christoph Anton Mitterer
2026-02-09  4:02                                             ` Qu Wenruo
2026-02-10  0:14                                               ` Christoph Anton Mitterer
2026-02-10 22:49                                                 ` Christoph Anton Mitterer
2026-03-04  3:59                                                   ` Christoph Anton Mitterer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYGvH2L6StMrLBOB@codewreck.org \
    --to=asmadeus@codewreck.org \
    --cc=calestyo@scientia.org \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    --cc=wqu@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.