From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Warner Losh <imp@bsdimp.com>
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org, "Thomas Huth" <thuth@redhat.com>,
"Cleber Rosa" <crosa@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Mauro Carvalho Chehab" <mchehab+huawei@kernel.org>,
"Joe Perches" <joe@perches.com>, "John Snow" <jsnow@redhat.com>
Subject: Re: [RFC PATCH v2 08/16] MAINTAINERS: be realistic about *-user
Date: Tue, 3 Feb 2026 09:43:05 +0000 [thread overview]
Message-ID: <aYHDKafOxzPL8DhL@redhat.com> (raw)
In-Reply-To: <CANCZdfqBKMt5qxfrEhudTbrkMzKRzVATuTWXnRnPttVj6UZ5HA@mail.gmail.com>
On Mon, Feb 02, 2026 at 02:57:57PM -0700, Warner Losh wrote:
> Just to follow up....
>
> On Fri, Jan 23, 2026 at 3:14 PM Warner Losh <imp@bsdimp.com> wrote:
>
> >
> >
> > On Fri, Jan 23, 2026 at 9:58 AM Daniel P. Berrangé <berrange@redhat.com>
> > wrote:
> >
> >> On Fri, Jan 23, 2026 at 08:12:33AM -0700, Warner Losh wrote:
> >> > On Fri, Jan 23, 2026 at 8:00 AM Alex Bennée <alex.bennee@linaro.org>
> >> wrote:
> >> >
> >> > > We should reflect the current status so users don't have unrealistic
> >> > > expectations of how quickly things can get reviewed and merged.
> >> > >
> >> > > Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> >> > >
> >> >
> >> > Reviewed-by: Warner Losh <imp@bsdimp.com>
> >>
> >> snip
> >>
> >> > A lot of the upstreaming work that's stalled would be ideal to tell
> >> claude
> >> > to do,
> >> > but I'm unsure the project's stance on using claude to move code, and
> >> git
> >> > log
> >> > 5 different trees to get the original author(s) of the code and make
> >> > trivial compile
> >> > tweaks.
> >>
> >> The critical thing we don't want is such tools making changes to the
> >> contents of source files.
> >>
> >> Automating the moving around of files is a non-issue.
> >>
> >> The use of AI for writing commit messages is arguably in scope of QEMU's
> >> AI policy given that is part of "the contribution", but it is less serious
> >> there, since commit messages don't have a copyright implication on what we
> >> host & distribute.
> >>
> >> More important is that the commit messages are accurate and well written.
> >> LLMs have a tendancy to be overly verbose about irrelevant stuff, and of
> >> course the well known danger of hallucinating nonsense. IME that makes it
> >> challenging to benefit from an LLM, due to review & re-writing overheads
> >> you then incurr to validate and fix their output.
> >>
> >
> > Yea, the commit messages llm would generate is 'do function X' and I'd then
> > fill it in from there, changing everything except X.
> >
> >
> >> I'd be wary of relying on an AI to extract and report on authorship of
> >> code. Accuracy is important there since it implies copyright ownership
> >> associations. Likewise a Signed-off-by tag should be added by humans
> >> only since it is a statement they are complying with the DCO policy.
> >>
> >
> > I'd be verifying everything done. Verification is relatively easy,
> > extraction is
> > the hard part. And the range of people it could be is tiny, so I'd know if
> > it
> > was making stuff up, or had gone off the rails... And I'd have it add
> > something
> > like 'Supposed-author: ' that I'd change once I verified it. That's ugly
> > grunt work,
> > but ugly grunt work I can do in an hour or two rather than the dozens of
> > hours
> > it usually takes me to do the extraction...
> >
>
> So, claude looks likeit's doing a passing fair job at this work. I plan on
> submitting
> a patch series for one of the minor files in the coming weeks (depending on
> how much time I can find to work on it). Any guidance you can give me up
> front?
>
> Before I submit, I plan on auditing every single change to make sure claude
> didn't introduce anything that's not in bsd-user's blitz branch. Make sure
> the authors
> are correct to the same level that I've been doing so far. And make sure
> I've rewritten
> all the commit messages.
>
> One question I have, should include these lines
> 🤖 Generated with [Claude Code](https://claude.com/claude-code)
> Co-Authored-By: Claude <noreply@anthropic.com>
Commit message tags like this are considered to be referring to the
code in the commit body, so that would be potentially misleading.
Personally, I also don't like the concept of providing free advertizing
for commercial tools in commit messages.
If you've exclusively used it for commit metadata, then IMHO it would
be sufficient to just mention this in the cover letter description,
and explicitly say it had no part in writing the code, etc.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2026-02-03 9:44 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 14:57 [RFC PATCH v2 00/16] MAINTAINER updates plus conversion of get_maintainers.pl to python Alex Bennée
2026-01-23 14:57 ` [RFC PATCH v2 01/16] MAINTAINERS: fix missing names Alex Bennée
2026-01-26 18:56 ` Pierrick Bouvier
2026-01-23 14:57 ` [RFC PATCH v2 02/16] MAINTAINERS: fix libvirt entry Alex Bennée
2026-01-23 14:57 ` [RFC PATCH v2 03/16] MAINTAINERS: regularise the status fields Alex Bennée
2026-01-23 14:57 ` [RFC PATCH v2 04/16] MAINTAINERS: remove myself as reviewer Alex Bennée
2026-01-26 18:56 ` Pierrick Bouvier
2026-01-23 14:57 ` [RFC PATCH v2 05/16] MAINTAINERS: add maintainer for docs/ Alex Bennée
2026-01-26 18:42 ` Philippe Mathieu-Daudé
2026-01-23 14:57 ` [RFC PATCH v2 06/16] MAINTAINERS: update Arm to Supported status Alex Bennée
2026-01-26 18:43 ` Philippe Mathieu-Daudé
2026-01-23 14:57 ` [RFC PATCH v2 07/16] MAINTAINERS: add reviewer for linux-user Alex Bennée
2026-01-26 18:43 ` Philippe Mathieu-Daudé
2026-01-23 14:57 ` [RFC PATCH v2 08/16] MAINTAINERS: be realistic about *-user Alex Bennée
2026-01-23 15:12 ` Warner Losh
2026-01-23 16:15 ` Alex Bennée
2026-01-23 22:09 ` Warner Losh
2026-01-26 14:37 ` Konstantin Ryabitsev
2026-01-23 16:57 ` Daniel P. Berrangé
2026-01-23 22:14 ` Warner Losh
2026-02-02 21:57 ` Warner Losh
2026-02-03 0:49 ` Warner Losh
2026-02-03 9:53 ` Daniel P. Berrangé
2026-02-03 9:43 ` Daniel P. Berrangé [this message]
2026-02-03 10:58 ` Markus Armbruster
2026-01-23 14:57 ` [RFC PATCH v2 09/16] scripts/get_maintainer.py: minimal argument parsing Alex Bennée
2026-01-23 14:57 ` [RFC PATCH v2 10/16] scripts/get_maintainer.py: resolve the source path Alex Bennée
2026-01-23 14:57 ` [RFC PATCH v2 11/16] scripts/get_maintainer.py: initial parsing of MAINTAINERS Alex Bennée
2026-01-23 14:57 ` [RFC PATCH v2 12/16] scripts/get_maintainer.py: add support for -f Alex Bennée
2026-01-23 14:57 ` [RFC PATCH v2 13/16] scripts/get_maintainer.py: add support reading patch files Alex Bennée
2026-01-23 14:57 ` [RFC PATCH v2 14/16] scripts/get_maintainer.py: add keyword (K:) support Alex Bennée
2026-01-23 14:57 ` [RFC PATCH v2 15/16] scripts/get_maintainer.py: implement basic git fallback support Alex Bennée
2026-01-23 14:57 ` [RFC PATCH v2 16/16] gitlab: add a check-maintainers task Alex Bennée
2026-01-23 15:42 ` [RFC PATCH v2 00/16] MAINTAINER updates plus conversion of get_maintainers.pl to python Pierrick Bouvier
2026-01-23 16:18 ` Alex Bennée
2026-01-23 18:04 ` Pierrick Bouvier
2026-01-23 17:54 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYHDKafOxzPL8DhL@redhat.com \
--to=berrange@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=crosa@redhat.com \
--cc=imp@bsdimp.com \
--cc=joe@perches.com \
--cc=jsnow@redhat.com \
--cc=mchehab+huawei@kernel.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.