All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Samuel Dionne-Riel <samuel@dionne-riel.com>
Cc: "Lorenzo Bianconi" <lorenzo@kernel.org>,
	"Jonathan Cameron" <jic23@kernel.org>,
	"David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: imu: lsm6dsx: Add alternative ACPI mount matrix retrieval
Date: Tue, 3 Feb 2026 13:32:35 +0200	[thread overview]
Message-ID: <aYHc08VZFQOlApIu@smile.fi.intel.com> (raw)
In-Reply-To: <20260201225450.1649001-4-samuel@dionne-riel.com>

On Sun, Feb 01, 2026 at 05:54:50PM -0500, Samuel Dionne-Riel wrote:
> This uses the SLA0 matrix, which is how the SMOCF05 configuration
> exposes the mounting information for the accelerometer.
> 
> On a limited sample size of one (1) unit, the SLG0 matrix is the
> identity matrix. It is unknown how the SLG0 mounting matrix would
> logically affect the data, if it differed from the identity matrix.
> After all, the IMU is mounted as one single unit, its mounting can't
> differ on the gyroscope compared to the accelerometer.
> 
> The new `st_lsm6dsx_read_acpi_mount_matrix` function currently only

st_lsm6dsx_read_acpi_mount_matrix()

> implements the *known* ACPI methods found in the wild, but the windows

Windows

> driver seems to indicate more integration-specific methods could exist.

...

> +static bool st_lsm6dsx_read_acpi_mount_matrix(struct device *dev,
> +				      struct iio_mount_matrix *orientation)
> +{
> +	return iio_read_acpi_mount_matrix(dev, orientation, "ROTM") ||
> +		iio_read_acpi_mount_matrix(dev, orientation, "SLA0");

Indentation is incorrect.

> +}

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-02-03 11:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-01 22:54 [PATCH v2 0/2] iio: imu: lsm6dsx: Support SMOCF05 ACPI ID Samuel Dionne-Riel
2026-02-01 22:54 ` [PATCH v2 1/2] iio: imu: lsm6dsx: Support SMOCF05 ACPI ID for LSM6DS3TR-C Samuel Dionne-Riel
2026-02-03 11:35   ` Andy Shevchenko
2026-02-01 22:54 ` [PATCH v2 2/2] iio: imu: lsm6dsx: Add alternative ACPI mount matrix retrieval Samuel Dionne-Riel
2026-02-03 11:32   ` Andy Shevchenko [this message]
2026-02-03 11:39 ` [PATCH v2 0/2] iio: imu: lsm6dsx: Support SMOCF05 ACPI ID Andy Shevchenko
2026-02-03 11:42   ` Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYHc08VZFQOlApIu@smile.fi.intel.com \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=samuel@dionne-riel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.