From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
"Andy Shevchenko" <andy@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"David Jander" <david@protonic.nl>
Subject: Re: [PATCH v4 10/13] iio: dac: ds4424: support per-variant output range limits
Date: Tue, 3 Feb 2026 13:46:25 +0200 [thread overview]
Message-ID: <aYHgEXRd76F8AnMU@smile.fi.intel.com> (raw)
In-Reply-To: <20260203093434.2548978-11-o.rempel@pengutronix.de>
On Tue, Feb 03, 2026 at 10:34:30AM +0100, Oleksij Rempel wrote:
> The DS4402/DS4404 variants operate with a 5-bit resolution (31 steps),
> whereas the DS4422/DS4424 support 7-bit (127 steps).
>
> Previously, the driver enforced a hardcoded 7-bit mask (DS4424_DAC_MASK)
> for all variants. This allowed users to write values exceeding the 5-bit
> range to DS4402/DS4404 devices, resulting in silent truncation or
> undefined behavior.
>
> Add a `result_mask` field to the chip_info structure to define the valid
> data range for each variant. Use this mask to:
> 1. Correctly mask register values in read_raw().
> 2. Return -EINVAL in write_raw() if the input value exceeds the
> variant's capabilities.
Makes sense.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-03 11:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 9:34 [PATCH v4 00/13] iio: dac: ds4424: add DS4402/DS4404 support and scale Oleksij Rempel
2026-02-03 9:34 ` [PATCH v4 01/13] iio: dac: ds4424: reject -128 RAW value Oleksij Rempel
2026-02-03 9:54 ` Andy Shevchenko
2026-02-03 10:28 ` Oleksij Rempel
2026-02-03 11:52 ` Andy Shevchenko
2026-02-05 20:41 ` Jonathan Cameron
2026-02-03 9:34 ` [PATCH v4 02/13] iio: dac: ds4424: refactor raw access to use bitwise operations Oleksij Rempel
2026-02-03 9:34 ` [PATCH v4 03/13] iio: dac: ds4424: ratelimit read errors and use device context Oleksij Rempel
2026-02-03 9:34 ` [PATCH v4 04/13] iio: dac: ds4424: sort headers alphabetically Oleksij Rempel
2026-02-03 9:34 ` [PATCH v4 05/13] iio: dac: ds4424: rename iio_info struct to avoid ambiguity Oleksij Rempel
2026-02-03 9:55 ` Andy Shevchenko
2026-02-03 9:34 ` [PATCH v4 06/13] iio: dac: ds4424: use device match data for chip info Oleksij Rempel
2026-02-03 10:03 ` Andy Shevchenko
2026-02-03 10:17 ` Oleksij Rempel
2026-02-03 11:51 ` Andy Shevchenko
2026-02-03 12:00 ` Oleksij Rempel
2026-02-03 14:56 ` Andy Shevchenko
2026-02-05 20:43 ` Jonathan Cameron
2026-02-06 7:57 ` Oleksij Rempel
2026-02-06 9:59 ` Andy Shevchenko
2026-02-09 9:22 ` Oleksij Rempel
2026-02-09 10:29 ` Andy Shevchenko
2026-02-03 9:34 ` [PATCH v4 07/13] iio: dac: ds4424: use fsleep() instead of usleep_range() Oleksij Rempel
2026-02-03 11:45 ` Andy Shevchenko
2026-02-03 9:34 ` [PATCH v4 08/13] dt-bindings: iio: dac: maxim,ds4424: add ds4402/ds4404 Oleksij Rempel
2026-02-03 9:34 ` [PATCH v4 09/13] iio: dac: ds4424: add DS4402/DS4404 device IDs Oleksij Rempel
2026-02-03 9:34 ` [PATCH v4 10/13] iio: dac: ds4424: support per-variant output range limits Oleksij Rempel
2026-02-03 11:46 ` Andy Shevchenko [this message]
2026-02-03 9:34 ` [PATCH v4 11/13] iio: dac: ds4424: convert to regmap Oleksij Rempel
2026-02-03 11:57 ` Andy Shevchenko
2026-02-03 9:34 ` [PATCH v4 12/13] dt-bindings: iio: dac: maxim,ds4424: add maxim,rfs-ohms property Oleksij Rempel
2026-02-03 9:34 ` [PATCH v4 13/13] iio: dac: ds4424: add Rfs-based scale and per-variant limits Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYHgEXRd76F8AnMU@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=david@protonic.nl \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=o.rempel@pengutronix.de \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.