From: Florian Westphal <fw@strlen.de>
To: Sun Jian <sun.jian.kdev@gmail.com>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Phil Sutter <phil@nwl.cc>, Simon Horman <horms@kernel.org>,
netfilter-devel@vger.kernel.org, netdev@vger.kernel.org,
bpf@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] netfilter: bpf: add missing declaration for bpf_ct_set_nat_info
Date: Tue, 3 Feb 2026 13:56:23 +0100 [thread overview]
Message-ID: <aYHwd2mMaVp-qFlp@strlen.de> (raw)
In-Reply-To: <20260203084323.2685140-1-sun.jian.kdev@gmail.com>
Sun Jian <sun.jian.kdev@gmail.com> wrote:
> When building with Sparse (C=2), the following warning is reported:
>
> net/netfilter/nf_nat_bpf.c:31:17: warning: symbol 'bpf_ct_set_nat_info'
> was not declared. Should it be static?
>
> This function is a BPF kfunc and must remain non-static to be visible
> to the BPF verifier via BTF. However, it lacks a proper declaration
> in the header file, which triggers the sparse warning.
>
> Fix this by adding the missing declaration in
> include/net/netfilter/nf_conntrack_bpf.h inside the CONFIG_NF_NAT
> conditional block.
Didn't Alexei tell you to not send more fixes like this?
https://lore.kernel.org/netfilter-devel/CAADnVQ+j8Q5+2KSsaddj3nmU1EkuRAt8XwM=zcSrfQfY+A1PsA@mail.gmail.com/
"No. Ignore the warning. Sparse is incorrect.
We have hundreds of such bogus warnings. Do NOT attempt to send
more patches to "fix" them."
I'm not applying patches when a subsystem maintainer already
said no.
next prev parent reply other threads:[~2026-02-03 12:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 8:43 [PATCH] netfilter: bpf: add missing declaration for bpf_ct_set_nat_info Sun Jian
2026-02-03 12:56 ` Florian Westphal [this message]
2026-02-03 13:05 ` sun jian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYHwd2mMaVp-qFlp@strlen.de \
--to=fw@strlen.de \
--cc=bpf@vger.kernel.org \
--cc=horms@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=phil@nwl.cc \
--cc=sun.jian.kdev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.