All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Ian Rogers <irogers@google.com>, Dmitry Dolgov <9erthalion6@gmail.com>
Cc: linux-perf-users@vger.kernel.org,
	Namhyung Kim <namhyung@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v1] perf tests: Test annotate with data type profiling and rust
Date: Tue, 3 Feb 2026 11:45:50 -0300	[thread overview]
Message-ID: <aYIKHjxCGFbReY7Y@x1> (raw)
In-Reply-To: <7d3n23li6drroxrdlpxn7ixehdeszkjdftah3zyngjl2qs22ef@yelcjv53v42o>

On Sun, Feb 01, 2026 at 11:33:54AM +0100, Dmitry Dolgov wrote:
> > On Fri, Jan 30, 2026 at 09:44:47AM +0100, Dmitry Dolgov wrote:
> > > I'm not managing to reproduce your results, can you please elaborate
> > > some more?
> > 
> > That's most unexpected for me, the test output I see looks like this:
> > 
> >          : 54     for _ in 1..count {
> >     0.00 :   5423b8: mov    %ecx,0x7c(%rsp)
> >     0.00 :   5423bc: mov    %eax,0x80(%rsp)
> >     0.00 :   5423c3: lea    0x7c(%rsp),%rdi
> >    12.28 :   5423c8: call   541f00 <core::iter::range::<impl core::iter::traits::iterator::Iterator for core::ops::range::Range<A>>::next>
> >     0.00 :   5423cd: mov    %eax,0x20(%rsp)
> >    10.21 :   5423d1: jmp    5423d3 <test_rs+0xb3>
> >     0.00 :   5423d3: mov    0x20(%rsp),%eax
> >     0.00 :   5423d7: mov    %eax,%eax
> >     0.00 :   5423d9: test   $0x1,%rax
> >     0.29 :   5423df: je     5423f6 <test_rs+0xd6>
> >          : 65     b.data1 += 1;
> >    13.69 :   5423e1: mov    0x48(%rsp),%rax     # data-type: struct Buf +0x18 (data1)
> >     0.00 :   5423e6: add    $0x1,%rax
> >     0.00 :   5423ea: mov    %rax,0x18(%rsp)     # data-type: u64 +0
> >     0.00 :   5423ef: setb   %al
> >    11.17 :   5423f2: jb     54243a <test_rs+0x11a>
> >     0.00 :   5423f4: jmp    542426 <test_rs+0x106>
> >     0.00 :   5423f6: lea    0x30(%rsp),%rdi
> >          : 73     }
> > 
> > Where '# data-type: struct Buf' is as far as I understand a manifestation of
> > data type profiling succeeding. But my environment has slightly different
> > version of rust -- I need to figure out what's going on here, thanks.
> 
> I've being testing this in the same way, but without any rust code --
> just on a simple datasym workload. Surprisingly, it seems that
> 'data-type: buf' marks are disappearing even in this case starting from:
> 
> c31040085914f1188720073baa43d1483693c0a3 (perf dwarf-regs: Clean up x86
> dwarf_regnum code)
 
> I'm not sure yet why this is happening, but don't see anything in the
> commit mentioning that -- since there are no code-with-type tests yet,
> maybe an unexpected side effect?

Ian, can you please take a look at this?

Cheers,

- Arnaldo

  reply	other threads:[~2026-02-03 14:45 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-27  8:30 [RFC PATCH v1] perf tests: Test annotate with data type profiling and rust Dmitrii Dolgov
2026-01-27 17:00 ` Arnaldo Carvalho de Melo
2026-01-30  8:44   ` Dmitry Dolgov
2026-02-01 10:33     ` Dmitry Dolgov
2026-02-03 14:45       ` Arnaldo Carvalho de Melo [this message]
2026-02-03 18:15         ` Ian Rogers
2026-02-04 21:52           ` Namhyung Kim
2026-02-04 22:18             ` Ian Rogers

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYIKHjxCGFbReY7Y@x1 \
    --to=acme@kernel.org \
    --cc=9erthalion6@gmail.com \
    --cc=irogers@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=namhyung@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.