From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Minu Jin <s9430939@naver.com>
Cc: gregkh@linuxfoundation.org, dan.carpenter@linaro.org,
trohan2000@gmail.com, andy@kernel.org,
linux-staging@lists.linux.dev, straube.linux@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 2/4] staging: rtl8723bs: replace rtw_zmalloc() with kzalloc()
Date: Tue, 3 Feb 2026 17:11:42 +0200 [thread overview]
Message-ID: <aYIQLjkhSfTvYJif@smile.fi.intel.com> (raw)
In-Reply-To: <20260131193001.303307-3-s9430939@naver.com>
On Sun, Feb 01, 2026 at 04:29:59AM +0900, Minu Jin wrote:
> replaces the wrapper function rtw_zmalloc() with kzalloc().
>
> I reviewed all the call sites to determine the appropriate GFP flags:
> - GFP_KERNEL: Used for initialization and configuration paths.
> init/probe, config/setup
>
> - GFP_ATOMIC: Used for critical real-time paths.
> including interrupts, timer handler, region where spinlocks are held
>
> Replace sizeof(struct val) with sizeof(*ptr).
> Use kmemdup() where possible.
Shouldn't be here. Are there kmemdup() conversions?
So, collect kmemdup() in the first (currently absent) patch followed by
kmalloc() followed by this change.
> Remove blank line after kzalloc().
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-03 15:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-31 19:29 [PATCH v4 0/4] remove memory allocation wrappers Minu Jin
2026-01-31 19:29 ` [PATCH v4 1/4] staging: rtl8723bs: replace rtw_malloc() with kmalloc() Minu Jin
2026-02-03 14:52 ` Andy Shevchenko
2026-01-31 19:29 ` [PATCH v4 2/4] staging: rtl8723bs: replace rtw_zmalloc() with kzalloc() Minu Jin
2026-02-03 15:11 ` Andy Shevchenko [this message]
2026-01-31 19:30 ` [PATCH v4 3/4] staging: rtl8723bs: replace skb allocation, copy wrappers Minu Jin
2026-02-03 15:13 ` Andy Shevchenko
2026-01-31 19:30 ` [PATCH v4 4/4] staging: rtl8723bs: remove unused allocation wrapper functions Minu Jin
2026-02-03 15:14 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYIQLjkhSfTvYJif@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=s9430939@naver.com \
--cc=straube.linux@gmail.com \
--cc=trohan2000@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.