From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: abdurrahman@nexthop.ai
Cc: Michal Simek <michal.simek@amd.com>,
Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v9 7/7] i2c: xiic: skip input clock setup on non-OF systems
Date: Tue, 3 Feb 2026 17:46:24 +0200 [thread overview]
Message-ID: <aYIYUNejGCVdekx7@smile.fi.intel.com> (raw)
In-Reply-To: <20260202-i2c-xiic-v9-7-ce4695f5267d@nexthop.ai>
On Mon, Feb 02, 2026 at 08:37:24PM +0000, Abdurrahman Hussain via B4 Relay wrote:
> Currently Linux does not implement ACPI ClockInput to describe clock
ClockInput() resource
> resources, unlike DT. However the xiic driver is happy if something
> magically enables the clock before the driver probes, and does not
> turn it off again. The clock should always be considered optional for
> ACPI.
...
> + if (is_of_node(dev_fwnode(dev))) {
> + i2c->clk = devm_clk_get_enabled(dev, NULL);
> + if (IS_ERR(i2c->clk))
> + return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk),
Haven't you seen my previous comments? Why 'pdev'?
> + "failed to enable input clock.\n");
> + }
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-02-03 15:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 20:37 [PATCH v9 0/7] i2c: xiic: use generic device property accessors Abdurrahman Hussain
2026-02-02 20:37 ` Abdurrahman Hussain via B4 Relay
2026-02-02 20:37 ` [PATCH v9 1/7] i2c: xiic: switch to devres managed APIs Abdurrahman Hussain
2026-02-02 20:37 ` Abdurrahman Hussain via B4 Relay
2026-02-02 20:37 ` [PATCH v9 2/7] i2c: xiic: remove duplicate error message Abdurrahman Hussain
2026-02-02 20:37 ` Abdurrahman Hussain via B4 Relay
2026-02-02 20:37 ` [PATCH v9 3/7] i2c: xiic: switch to generic device property accessors Abdurrahman Hussain
2026-02-02 20:37 ` Abdurrahman Hussain via B4 Relay
2026-02-02 20:37 ` [PATCH v9 4/7] i2c: xiic: cosmetic cleanup Abdurrahman Hussain
2026-02-02 20:37 ` Abdurrahman Hussain via B4 Relay
2026-02-03 15:42 ` Andy Shevchenko
2026-02-03 18:59 ` Abdurrahman Hussain
2026-02-04 1:11 ` Andi Shyti
2026-02-02 20:37 ` [PATCH v9 5/7] i2c: xiic: cosmetic: use resource format specifier in debug log Abdurrahman Hussain
2026-02-02 20:37 ` Abdurrahman Hussain via B4 Relay
2026-02-02 20:37 ` [PATCH v9 6/7] i2c: xiic: use numbered adapter registration Abdurrahman Hussain
2026-02-02 20:37 ` Abdurrahman Hussain via B4 Relay
2026-02-03 15:45 ` Andy Shevchenko
2026-02-03 18:14 ` Abdurrahman Hussain
2026-02-03 18:31 ` Andrew Lunn
2026-02-03 18:50 ` Abdurrahman Hussain
2026-02-03 19:57 ` Abdurrahman Hussain
2026-02-03 19:58 ` Andrew Lunn
2026-02-02 20:37 ` [PATCH v9 7/7] i2c: xiic: skip input clock setup on non-OF systems Abdurrahman Hussain
2026-02-02 20:37 ` Abdurrahman Hussain via B4 Relay
2026-02-03 15:46 ` Andy Shevchenko [this message]
2026-02-03 18:38 ` Abdurrahman Hussain
2026-02-03 23:38 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYIYUNejGCVdekx7@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=abdurrahman@nexthop.ai \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.