From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1BF843ED119 for ; Wed, 4 Feb 2026 11:57:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.67 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770206279; cv=none; b=N19XFJxHIaT5GOmoP6rRgLwJPJBJqsvi/lBFIcoCeBEAUbtJbNPcaDued5sbqTE0ytW9W0ltsFqt326sXOMbAWwcOV46IvQWiI5m4pYp/rL2xiC1kWnr1SNgQCmXCkBqyb3OyqkVkhJIA75X8eLckEqM43ve2aBc8/u+HcVacxo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770206279; c=relaxed/simple; bh=rPIn+Mra4o1bR6EHRdELYXEUCRMxJ4FKYJobQW4iQuY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Ol1mpleIWdw8/9hSk0BULYDwN2kZY0Zbo6UbcD9HAjzBfKrvi4S+mrYvgWpyB3iGtrdyCvuvlEj3cr7yRsZJAfIpEiDTn9CJS9tnoQYFcNO43K/R+/7xFEl9KJ0HrkTNltHcxtQjErJF+5dZFFd/r3vI+mg3ycz/HOL/gOZ6Z8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=YpHMRirH; arc=none smtp.client-ip=209.85.221.67 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="YpHMRirH" Received: by mail-wr1-f67.google.com with SMTP id ffacd0b85a97d-42fb4eeb482so4609275f8f.0 for ; Wed, 04 Feb 2026 03:57:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770206277; x=1770811077; darn=lists.linux.dev; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=pfxMamMtxLHcw6K0Fqk6/zfs3lYEE3ZNz2eLveiTn0g=; b=YpHMRirHobbTWQYSPWwfxkgFkOdHfBFgU8YJLbs7SVmqvfyM6/CNwuFbsq9BV5tTxO KE+jtwHJgJthgwNMBWY9iUHNgLFbYp6goiKNcaG6ra0+5wdqy74uXKbSe6N7dTiEwn8n gvmTafJyVynHHwSUm5RdKnAW4FKNP/bEWFS0Zeuk29YnJqeAaDuiJCY27XzoEW56jy5J 7TFz0o6uOm5loGQJs8WkvC98iz5b6dJjsXAfRYKb/9moGd/UB9SH0uSFOL6bQ48Y5Xzr /CQ7+DuWcOV0Ha4+c5yW0749vHJ0dRoUy6+f5Nx765Ul5JgU+001KZT5AO2hZjOrC6KL Azwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770206277; x=1770811077; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pfxMamMtxLHcw6K0Fqk6/zfs3lYEE3ZNz2eLveiTn0g=; b=RL0Ld/HvYv+OMYpmrdssuQRgUL3EmX3lvuRivDReMCTStHRsev3A0v9x/aAZ9bVhaI Ag08ScbYixTHI+qWcxCrX/CN2FYCyqgvekCK4mOKyig6SEdVwphnph3aI7QZxkssq7dp LonMzyy9sISXAxKW19Ux7Bj56/+Cxe6QJ1XRFHix5/jFrmrXcUY+fjbdoVYfQDMSurQ9 6iHL22W0reFWyPSeNpGR5O25Gx57fcvEFpi79nuNDGf3xUBU6dbY531YkENu4sYKCtIL EUKQlSLG0c9iP3Owi/ZXr/UXLd9cbFlfZ8C8Zn4g8M3GK3KCT0zfqsGJIJJ9JD8oX6x/ 7GhQ== X-Gm-Message-State: AOJu0YxO3OZXUd6bOvtyqpDmPCGQhgg9zfW08JZwQ5Oun3zHEOtOhvuW vgOts6YXFWf8NWNqSU4a5K4MlCZxjajl8Gg2tjteNf1/jZ/8bYXTbJbCNFcNSOFZ/6U= X-Gm-Gg: AZuq6aK2ZswZxTCghNU/O7qgbS4PW96sMXRxJQJ3zrboGccSwhJQnWhuSq7LBvKweEb P+SDuItdHuvHhgzU+Ji4qhjv95gHEhw9EEdqt2jp+Hn7OgH05X52IbFrOvBM17cZS+c0uWGwK1H Wkezf06X5YL/YAwuZZJ410ovc04DMg0VomLCAHylfJfdigHoIWrbLgaO4u+lky+DnfxCOxjGIQd 6LqMjtq5M2u6/ZCcmaA70PfDmR14GPNJh1nj2GsED/LpKFiEM50oYqy//YVV6Sv4mdLcXcXle3+ d0AK6e6e1J9s+mySlc4LHUeN+Ju6B0aKYBLi11PqxMpZXZHIFgEc3N3U0GMF0WdM9MjamymJrX9 DA9uvl98655KYW1Zhkyn7udgqMRdOCXQ2je4gTzDLw25aWOf4oL1NwHQIR0IuQ5/IRPNyyouALV LzkYil4K4BU15xBAo9 X-Received: by 2002:a5d:5f45:0:b0:435:b0e7:ea1 with SMTP id ffacd0b85a97d-43617e400f6mr3907970f8f.19.1770206277324; Wed, 04 Feb 2026 03:57:57 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43618058473sm6252472f8f.22.2026.02.04.03.57.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 Feb 2026 03:57:56 -0800 (PST) Date: Wed, 4 Feb 2026 14:57:53 +0300 From: Dan Carpenter To: "Chia-Yu Chang (Nokia)" Cc: "oe-kbuild@lists.linux.dev" , "lkp@intel.com" , "oe-kbuild-all@lists.linux.dev" , Paolo Abeni , Eric Dumazet Subject: Re: [linux-next:master 11349/11582] net/ipv4/tcp_output.c:754 tcp_options_write() error: we previously assumed 'tp' could be null (see line 722) Message-ID: References: <202602041310.ZBuXDXC5-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: These are automated emails based on static analysis. The NULL checking in this function is weird because there are a bunch of unchecked dereferences followed by a couple NULL checks and then followed by several unchecked dereferences. I've actually sent this warning before and the code was explained. :( https://lore.kernel.org/all/fce974f0-cea9-fa92-ecfc-4f7cc4fc95e2@arista.com/ Sorry, I should have been more careful before sending duplicates. :( regards, dan carpenter