From: Alice Ryhl <aliceryhl@google.com>
To: Gary Guo <gary@garyguo.net>
Cc: Marco Crivellari <marco.crivellari@suse.com>,
linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org,
Tejun Heo <tj@kernel.org>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Frederic Weisbecker <frederic@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Michal Hocko <mhocko@suse.com>, Miguel Ojeda <ojeda@kernel.org>,
Alex Gaynor <alex.gaynor@gmail.com>
Subject: Re: [PATCH v4 1/2] rust: add system_dfl() around the new system_dfl_wq
Date: Wed, 4 Feb 2026 10:52:22 +0000 [thread overview]
Message-ID: <aYMk5skDB0Rk7vWS@google.com> (raw)
In-Reply-To: <DG5G52FJ0I1F.1OHNFAXKXOZ1R@garyguo.net>
On Tue, Feb 03, 2026 at 03:53:39PM +0000, Gary Guo wrote:
> Is there any reason that we cannot migrate the user early by just returning
> `system_dfl_wq` inside `system_unbound`? (I guess the question also applies on
> why system_unbound_wq cannot be the same pointer as system_dfl_wq).
I think this is confusing. Let's just rename it here and update the
callers. Otherwise Rust gets out of sync with C naming-wise.
> Also, I feel that `dfl` is not a very intuitive name. I searched the list and
> the commit history for a while and cannot find the exact explaination on what it
> means? Does it mean "default" or something else?
This I agree with. dfl is not a good name. Let's at least call it
"default" or "unbound" or whatever.
Alice
next prev parent reply other threads:[~2026-02-04 10:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 15:28 [PATCH v4 0/2] Add new workqueue wrapper and enqueue on cpu functions Marco Crivellari
2026-02-03 15:28 ` [PATCH v4 1/2] rust: add system_dfl() around the new system_dfl_wq Marco Crivellari
2026-02-03 15:39 ` Alice Ryhl
2026-02-03 15:53 ` Gary Guo
2026-02-04 9:43 ` Marco Crivellari
2026-02-04 16:50 ` Gary Guo
2026-02-09 17:14 ` Marco Crivellari
2026-02-04 10:52 ` Alice Ryhl [this message]
2026-02-04 15:16 ` Marco Crivellari
2026-02-04 0:28 ` kernel test robot
2026-02-03 15:28 ` [PATCH v4 2/2] rust: add system_percpu() and per-cpu enqueue functions Marco Crivellari
2026-02-03 15:39 ` Alice Ryhl
2026-02-04 1:29 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYMk5skDB0Rk7vWS@google.com \
--to=aliceryhl@google.com \
--cc=alex.gaynor@gmail.com \
--cc=bigeasy@linutronix.de \
--cc=frederic@kernel.org \
--cc=gary@garyguo.net \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marco.crivellari@suse.com \
--cc=mhocko@suse.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.