From: Yohei Kojima <yk@y-koj.net>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>, Simon Horman <horms@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
netdev@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] docs: ethtool: clarify the bit-by-bit bitset format description
Date: Wed, 4 Feb 2026 21:51:07 +0900 [thread overview]
Message-ID: <aYNAuwjJrkV66mD7@desktop.y-koj.net> (raw)
In-Reply-To: <20260203195338.1b1fa65a@kernel.org>
On Tue, Feb 03, 2026 at 07:53:38PM -0800, Jakub Kicinski wrote:
> On Tue, 3 Feb 2026 00:17:19 +0900 Yohei Kojima wrote:
> > Clarify the format and semantics of the bit-by-bit bitset by the
> > following changes:
> > * Explicitly describe the mandatory and optional fields in one paragraph
> > * Detail what happens if ETHTOOL_A_BITSET_NOMASK is set
> > * Clarify that users can set both BIT_INDEX and BIT_NAME fields
>
> To be honest I'm not entirely sure which doc is easier to follow,
> before or after this patch :(
Thank you for the feedback. In the v2 patch, I'll focus on adding the
missing explanation rather than restructuring the entire paragraph.
Thank you,
Yohei
prev parent reply other threads:[~2026-02-04 12:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 15:17 [PATCH net-next] docs: ethtool: clarify the bit-by-bit bitset format description Yohei Kojima
2026-02-04 3:53 ` Jakub Kicinski
2026-02-04 12:51 ` Yohei Kojima [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYNAuwjJrkV66mD7@desktop.y-koj.net \
--to=yk@y-koj.net \
--cc=andrew@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.