All of lore.kernel.org
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: Tycho Andersen <tycho@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
	Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Mark Rutland <mark.rutland@arm.com>,
	Alexander Shishkin <alexander.shishkin@linux.intel.com>,
	Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
	Adrian Hunter <adrian.hunter@intel.com>,
	James Clark <james.clark@linaro.org>,
	Chun-Tse Shao <ctshao@google.com>,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ravi Bangoria <ravi.bangoria@amd.com>,
	K Prateek Nayak <kprateek.nayak@amd.com>
Subject: Re: [PATCH] perf: fix segfault in `lock contention -b`
Date: Wed, 4 Feb 2026 13:26:32 -0800	[thread overview]
Message-ID: <aYO5iCWb3P_9YIVr@google.com> (raw)
In-Reply-To: <aYNjwvYkvk0Ul2Jl@tycho.pizza>

Hello,

On Wed, Feb 04, 2026 at 08:20:34AM -0700, Tycho Andersen wrote:
> On Tue, Jan 13, 2026 at 01:18:52PM -0800, Namhyung Kim wrote:
> > On Mon, Jan 12, 2026 at 09:15:53AM -0700, Tycho Andersen wrote:
> > > On Fri, Jan 09, 2026 at 04:49:01PM -0800, Namhyung Kim wrote:
> > > > That said, can you add a NULL check in the init_numa_data() instead
> > > > and see how far it can go?
> > > 
> > > Looks like not much further, it fails in lock_contention_bpf__load():
> > > 
> > > ./perf lock contention -b
> > > libbpf: kernel BTF is missing at '/sys/kernel/btf/vmlinux', was CONFIG_DEBUG_INFO_BTF enabled?
> > > libbpf: failed to find valid kernel BTF
> > > libbpf: kernel BTF is missing at '/sys/kernel/btf/vmlinux', was CONFIG_DEBUG_INFO_BTF enabled?
> > > libbpf: failed to find valid kernel BTF
> > > libbpf: Error loading vmlinux BTF: -ESRCH
> > > libbpf: failed to load BPF skeleton 'lock_contention_bpf': -ESRCH
> > > Failed to load lock-contention BPF skeleton
> > > lock contention BPF setup failed
> > 
> > Thanks for checking this.  I think it's ok to fail like this when BTF is
> > not enabled.  Let me see if I can make some changes to run without it
> > later.
> 
> Gentle ping, I was just reminded of this crash again this morning.

Sorry for the delay.  Please send a fix with the NULL check in the
init_numa_data().  I think it'd be simpler and easier to improve.

Thanks,
Namhyung


  reply	other threads:[~2026-02-04 21:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-09 16:44 [PATCH] perf: fix segfault in `lock contention -b` Tycho Andersen
2026-01-10  0:49 ` Namhyung Kim
2026-01-12 16:15   ` Tycho Andersen
2026-01-13 21:18     ` Namhyung Kim
2026-02-04 15:20       ` Tycho Andersen
2026-02-04 21:26         ` Namhyung Kim [this message]
2026-01-13  3:11 ` K Prateek Nayak
2026-01-13 15:48   ` Tycho Andersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYO5iCWb3P_9YIVr@google.com \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=ctshao@google.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=jolsa@kernel.org \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=ravi.bangoria@amd.com \
    --cc=tycho@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.