All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alice Ryhl <aliceryhl@google.com>
To: jongan.kim@lge.com
Cc: a.hindborg@kernel.org, arve@android.com,
	bjorn3_gh@protonmail.com,  boqun.feng@gmail.com,
	brauner@kernel.org, cmllamas@google.com,  dakr@kernel.org,
	daniel.almeida@collabora.com, gary@garyguo.net,
	 gregkh@linuxfoundation.org, heesu0025.kim@lge.com,
	ht.hong@lge.com,  jungsu.hwang@lge.com, kernel-team@android.com,
	linux-kernel@vger.kernel.org,  lossin@kernel.org,
	ojeda@kernel.org, rust-for-linux@vger.kernel.org,
	 sanghun.lee@lge.com, seulgi.lee@lge.com, sunghoon.kim@lge.com,
	 tamird@gmail.com, tkjos@android.com, tmgross@umich.edu,
	 viresh.kumar@linaro.org, vitaly.wool@konsulko.se,
	yury.norov@gmail.com
Subject: Re: [PATCH v3 3/3] rust_binder: handle PID namespace conversion for freeze operation
Date: Thu, 5 Feb 2026 08:20:48 +0000	[thread overview]
Message-ID: <aYRS4K035jOL1fXv@google.com> (raw)
In-Reply-To: <20260205050128.17532-1-jongan.kim@lge.com>

On Thu, Feb 05, 2026 at 02:01:28PM +0900, jongan.kim@lge.com wrote:
> On Wed, Feb 04 2026 10:50:31AM +0000, Alice Ryhl wrote:
> > On Wed, Feb 04, 2026 at 06:11:47PM +0900, jongan.kim@lge.com wrote:
> > > 3. Regarding the search mechanism and vec efficiency improvements you
> > > mentioned, these seem like valuable optimizations but would represent
> > > a broader architectural change to the binder driver.
> > 
> > Improving get_procs_with_pid() seems like a separate thing. Perhaps it
> > could be part of this other series:
> > https://lore.kernel.org/all/20260201000817.275382-1-shivamklr@cock.li/
> > 
> > Improving it here should only happen if you need to rewrite said
> > function *anyway*.
> 
> Since we're changing the implementation to use task-based comparison instead
> of PID-based comparison, we won't be using get_procs_with_pid() anymore and
> will need to write a new function (e.g., get_procs_with_task()).
> 
> Would this approach align with the Rust binder development direction?

Replacing get_procs_with_pid() with a new get_procs_with_task() sounds
reasonable to me.

Alice

      reply	other threads:[~2026-02-05  8:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-03  6:59 [PATCH v3 0/3] binder: handle PID namespace conversion for freeze operation jongan.kim
2026-02-03  6:59 ` [PATCH v3 1/3] " jongan.kim
2026-02-03 20:38   ` Yury Norov
2026-02-04  9:05     ` jongan.kim
2026-02-04 17:04       ` Yury Norov
2026-02-05  5:30         ` jongan.kim
2026-02-03  6:59 ` [PATCH v3 2/3] rust: pid: add Pid abstraction and init_ns helper jongan.kim
2026-02-03 13:01   ` Gary Guo
2026-02-03  6:59 ` [PATCH v3 3/3] rust_binder: handle PID namespace conversion for freeze operation jongan.kim
2026-02-03 12:59   ` Gary Guo
2026-02-04  9:11     ` jongan.kim
2026-02-04 10:50       ` Alice Ryhl
2026-02-05  5:01         ` jongan.kim
2026-02-05  8:20           ` Alice Ryhl [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aYRS4K035jOL1fXv@google.com \
    --to=aliceryhl@google.com \
    --cc=a.hindborg@kernel.org \
    --cc=arve@android.com \
    --cc=bjorn3_gh@protonmail.com \
    --cc=boqun.feng@gmail.com \
    --cc=brauner@kernel.org \
    --cc=cmllamas@google.com \
    --cc=dakr@kernel.org \
    --cc=daniel.almeida@collabora.com \
    --cc=gary@garyguo.net \
    --cc=gregkh@linuxfoundation.org \
    --cc=heesu0025.kim@lge.com \
    --cc=ht.hong@lge.com \
    --cc=jongan.kim@lge.com \
    --cc=jungsu.hwang@lge.com \
    --cc=kernel-team@android.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lossin@kernel.org \
    --cc=ojeda@kernel.org \
    --cc=rust-for-linux@vger.kernel.org \
    --cc=sanghun.lee@lge.com \
    --cc=seulgi.lee@lge.com \
    --cc=sunghoon.kim@lge.com \
    --cc=tamird@gmail.com \
    --cc=tkjos@android.com \
    --cc=tmgross@umich.edu \
    --cc=viresh.kumar@linaro.org \
    --cc=vitaly.wool@konsulko.se \
    --cc=yury.norov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.