From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Hugo Villeneuve <hugo@hugovil.com>
Cc: hvilleneuve@dimonoff.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: input: add GPIO charlieplex keypad
Date: Thu, 5 Feb 2026 01:24:05 -0800 [thread overview]
Message-ID: <aYRg2vP4Lfqm61qH@google.com> (raw)
In-Reply-To: <20260203155023.536103-2-hugo@hugovil.com>
Hi Hugo,
On Tue, Feb 03, 2026 at 10:49:47AM -0500, Hugo Villeneuve wrote:
> From: Hugo Villeneuve <hvilleneuve@dimonoff.com>
>
> Add DT bindings for GPIO charlieplex keypad.
>
...
> + linux,no-autorepeat:
> + type: boolean
> + description: Do not enable autorepeat feature.
Let's use standard "autorepeat" property to enable autorepeat when
needed.
> +
> + gpio-activelow:
> + type: boolean
> + description:
> + Force GPIO polarity to active low.
> + In the absence of this property GPIOs are treated as active high.
No, the polarity should be encoded in individual GPIOs, not via a
separate property.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2026-02-05 9:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-03 15:49 [PATCH 0/2] input: add GPIO-based charlieplex keypad Hugo Villeneuve
2026-02-03 15:49 ` [PATCH 1/2] dt-bindings: input: add GPIO " Hugo Villeneuve
2026-02-03 18:17 ` Rob Herring (Arm)
2026-02-03 19:06 ` Hugo Villeneuve
2026-02-05 9:24 ` Dmitry Torokhov [this message]
2026-02-13 16:26 ` Hugo Villeneuve
2026-02-03 15:49 ` [PATCH 2/2] Input: charlieplex_keypad: " Hugo Villeneuve
2026-02-03 23:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aYRg2vP4Lfqm61qH@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hugo@hugovil.com \
--cc=hvilleneuve@dimonoff.com \
--cc=krzk+dt@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.